mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 18:11:00 +03:00
d12614521a
There are some issues with the way the seq_file interface is implemented for kstats backed by linked lists (zfs_dbgmsgs and certain per-pool debugging info): * We don't account for the fact that seq_file sometimes visits a node multiple times, which results in missing messages when read through procfs. * We don't keep separate state for each reader of a file, so concurrent readers will receive incorrect results. * We don't account for the fact that entries may have been removed from the list between read syscalls, so reading from these files in procfs can cause the system to crash. This change fixes these issues and adds procfs_list, a wrapper around a linked list which abstracts away the details of implementing the seq_file interface for a list and exposing the contents of the list through procfs. Reviewed by: Don Brady <don.brady@delphix.com> Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed by: Brad Lewis <brad.lewis@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: John Gallagher <john.gallagher@delphix.com> External-issue: LX-1211 Closes #7819
72 lines
2.1 KiB
C
72 lines
2.1 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
/*
|
|
* Copyright (c) 2018 by Delphix. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _SPL_PROCFS_LIST_H
|
|
#define _SPL_PROCFS_LIST_H
|
|
|
|
#include <sys/kstat.h>
|
|
#include <sys/mutex.h>
|
|
#include <linux/proc_fs.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
typedef struct procfs_list procfs_list_t;
|
|
struct procfs_list {
|
|
/* Accessed only by user of a procfs_list */
|
|
void *pl_private;
|
|
|
|
/*
|
|
* Accessed both by user of a procfs_list and by procfs_list
|
|
* implementation
|
|
*/
|
|
kmutex_t pl_lock;
|
|
list_t pl_list;
|
|
|
|
/* Accessed only by procfs_list implementation */
|
|
uint64_t pl_next_id;
|
|
int (*pl_show)(struct seq_file *f, void *p);
|
|
int (*pl_show_header)(struct seq_file *f);
|
|
int (*pl_clear)(procfs_list_t *procfs_list);
|
|
size_t pl_node_offset;
|
|
kstat_proc_entry_t pl_kstat_entry;
|
|
};
|
|
|
|
typedef struct procfs_list_node {
|
|
list_node_t pln_link;
|
|
uint64_t pln_id;
|
|
} procfs_list_node_t;
|
|
|
|
void procfs_list_install(const char *module,
|
|
const char *name,
|
|
procfs_list_t *procfs_list,
|
|
int (*show)(struct seq_file *f, void *p),
|
|
int (*show_header)(struct seq_file *f),
|
|
int (*clear)(procfs_list_t *procfs_list),
|
|
size_t procfs_list_node_off);
|
|
void procfs_list_uninstall(procfs_list_t *procfs_list);
|
|
void procfs_list_destroy(procfs_list_t *procfs_list);
|
|
|
|
void procfs_list_add(procfs_list_t *procfs_list, void *p);
|
|
|
|
#endif /* _SPL_PROCFS_LIST_H */
|