mirror_zfs/module
Richard Yao 72540ea314 zfsdev_getminor() should check for invalid file handles
Unit testing at ClusterHQ found that passing an invalid file handle to
zfs_ioc_hold results in a NULL pointer dereference on a system without
assertions:

IP: [<ffffffffa0218aa0>] zfsdev_getminor+0x10/0x20 [zfs]
Call Trace:
[<ffffffffa021b4b0>] zfs_onexit_fd_hold+0x20/0x40 [zfs]
[<ffffffffa0214043>] zfs_ioc_hold+0x93/0xd0 [zfs]
[<ffffffffa0215890>] zfsdev_ioctl+0x200/0x500 [zfs]

An assertion would have caught this had they been enabled, but this is
something that the kernel module should handle without failing.  We
resolve this by searching the linked list to ensure that the file
handle's private_data points to a valid zfsdev_state_t.

Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Andriy Gapon <avg@FreeBSD.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #3506
2015-06-22 17:02:13 -07:00
..
avl Illumos 4873 - zvol unmap calls can take a very long time for larger datasets 2015-04-28 16:24:03 -07:00
nvpair Retire spl_module_init()/spl_module_fini() 2015-02-24 11:37:44 -08:00
unicode Retire spl_module_init()/spl_module_fini() 2015-02-24 11:37:44 -08:00
zcommon Illumos 5027 - zfs large block support 2015-05-11 12:23:16 -07:00
zfs zfsdev_getminor() should check for invalid file handles 2015-06-22 17:02:13 -07:00
zpios Retire spl_module_init()/spl_module_fini() 2015-02-24 11:37:44 -08:00
.gitignore gitignore: anchor entries at their respective directory 2013-04-02 10:50:17 -07:00
Makefile.in Fix modules installation directory 2014-10-28 09:46:14 -07:00