Files
mirror_zfs/include/sys
Brian Behlendorf 6857950e46 Fix zpl_mount() deadlock
Commit 93b43af10 inadvertently introduced the following scenario which
can result in a deadlock.  This issue was most easily reproduced by
LXD containers using a ZFS storage backend but should be reproducible
under any workload which is frequently mounting and unmounting.

-- THREAD A --
spa_sync()
  spa_sync_upgrades()
    rrw_enter(&dp->dp_config_rwlock, RW_WRITER, FTAG); <- Waiting on B

-- THREAD B --
mount_fs()
  zpl_mount()
    zpl_mount_impl()
      dmu_objset_hold()
        dmu_objset_hold_flags()
          dsl_pool_hold()
            dsl_pool_config_enter()
              rrw_enter(&dp->dp_config_rwlock, RW_READER, tag);
    sget()
      sget_userns()
        grab_super()
          down_write(&s->s_umount); <- Waiting on C

-- THREAD C --
cleanup_mnt()
  deactivate_super()
    down_write(&s->s_umount);
    deactivate_locked_super()
      zpl_kill_sb()
        kill_anon_super()
          generic_shutdown_super()
            sync_filesystem()
              zpl_sync_fs()
                zfs_sync()
                  zil_commit()
                    txg_wait_synced() <- Waiting on A

Reviewed by: Alek Pinchuk <apinchuk@datto.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #7598 
Closes #7659 
Closes #7691 
Closes #7693
2018-07-06 02:46:51 -07:00
..
2018-05-07 17:19:56 -07:00
2017-06-30 11:11:01 -07:00
2018-01-30 10:27:31 -06:00
2016-01-08 15:08:19 -08:00
2016-06-28 13:47:02 -07:00
2014-07-29 10:55:29 -07:00
2017-10-17 16:49:03 -07:00
2013-11-04 11:18:14 -08:00
2017-07-13 13:54:00 -04:00
2013-11-04 11:17:48 -08:00
2017-01-03 11:31:18 -06:00
2017-07-13 13:54:00 -04:00
2014-08-13 10:35:00 -07:00
2016-04-21 09:49:25 -07:00
2016-06-07 09:16:52 -07:00
2014-07-30 09:20:35 -07:00
2016-06-24 13:13:21 -07:00
2016-12-01 16:39:06 -07:00
2015-01-06 16:53:24 -08:00
2017-01-03 11:31:18 -06:00
2017-07-13 13:54:00 -04:00
2011-02-10 09:21:43 -08:00
2013-11-04 10:55:25 -08:00
2018-01-30 10:27:30 -06:00
2017-03-10 09:51:33 -08:00
2017-03-10 09:51:33 -08:00
2013-12-18 16:46:35 -08:00
2017-03-10 09:51:33 -08:00
2017-03-10 09:51:33 -08:00
2017-03-10 09:51:33 -08:00
2018-07-06 02:46:51 -07:00
2017-03-29 12:24:51 -07:00
2018-05-07 17:19:56 -07:00
2017-07-12 13:05:37 -07:00