mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-18 10:21:01 +03:00
628fc52137
spl_inode_{lock,unlock} are triggering possible recursive locking
warnings from lockdep. The warning is a false positive.
The lock is used to protect a parent directory during delete/add
operations, used in zfs when writing/removing the cache file. The inode
lock is taken on both the parent inode and the file inode.
VFS provides an enum to subclass the lock. This patch changes the
spin_lock call to _nested version and uses the provided enum.
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #480
84 lines
2.7 KiB
C
84 lines
2.7 KiB
C
/*****************************************************************************\
|
|
* Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
|
|
* Copyright (C) 2007 The Regents of the University of California.
|
|
* Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
|
|
* Written by Brian Behlendorf <behlendorf1@llnl.gov>.
|
|
* UCRL-CODE-235197
|
|
*
|
|
* This file is part of the SPL, Solaris Porting Layer.
|
|
* For details, see <http://zfsonlinux.org/>.
|
|
*
|
|
* The SPL is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* The SPL is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with the SPL. If not, see <http://www.gnu.org/licenses/>.
|
|
\*****************************************************************************/
|
|
|
|
#ifndef _SPL_FILE_COMPAT_H
|
|
#define _SPL_FILE_COMPAT_H
|
|
|
|
#include <linux/fs.h>
|
|
#ifdef HAVE_FDTABLE_HEADER
|
|
#include <linux/fdtable.h>
|
|
#endif
|
|
|
|
static inline struct file *
|
|
spl_filp_open(const char *name, int flags, int mode, int *err)
|
|
{
|
|
struct file *filp = NULL;
|
|
int rc;
|
|
|
|
filp = filp_open(name, flags, mode);
|
|
if (IS_ERR(filp)) {
|
|
rc = PTR_ERR(filp);
|
|
if (err)
|
|
*err = rc;
|
|
filp = NULL;
|
|
}
|
|
return filp;
|
|
}
|
|
|
|
#define spl_filp_close(f) filp_close(f, NULL)
|
|
#define spl_filp_poff(f) (&(f)->f_pos)
|
|
#define spl_filp_write(fp, b, s, p) (fp)->f_op->write((fp), (b), (s), p)
|
|
|
|
static inline int
|
|
spl_filp_fallocate(struct file *fp, int mode, loff_t offset, loff_t len)
|
|
{
|
|
int error = -EOPNOTSUPP;
|
|
|
|
#ifdef HAVE_FILE_FALLOCATE
|
|
if (fp->f_op->fallocate)
|
|
error = fp->f_op->fallocate(fp, mode, offset, len);
|
|
#else
|
|
#ifdef HAVE_INODE_FALLOCATE
|
|
if (fp->f_dentry && fp->f_dentry->d_inode &&
|
|
fp->f_dentry->d_inode->i_op->fallocate)
|
|
error = fp->f_dentry->d_inode->i_op->fallocate(
|
|
fp->f_dentry->d_inode, mode, offset, len);
|
|
#endif /* HAVE_INODE_FALLOCATE */
|
|
#endif /*HAVE_FILE_FALLOCATE */
|
|
|
|
return (error);
|
|
}
|
|
|
|
#ifdef HAVE_2ARGS_VFS_FSYNC
|
|
#define spl_filp_fsync(fp, sync) vfs_fsync(fp, sync)
|
|
#else
|
|
#define spl_filp_fsync(fp, sync) vfs_fsync(fp, (fp)->f_dentry, sync)
|
|
#endif /* HAVE_2ARGS_VFS_FSYNC */
|
|
|
|
#define spl_inode_lock(ip) mutex_lock_nested(&(ip)->i_mutex, I_MUTEX_PARENT)
|
|
#define spl_inode_unlock(ip) mutex_unlock(&(ip)->i_mutex)
|
|
|
|
#endif /* SPL_FILE_COMPAT_H */
|
|
|