mirror_zfs/cmd/zpool
Rob Norris 3e7e19e028 pool_iter_refresh: don't refresh pools twice
In "all pools" mode, pool_iter_refresh() will call zpool_iter(), which
will call zpool_refresh_stats() before calling add_pool(). If we already
have the pool, this is a different handle, so we just release it and
return. Back in pool_iter_refresh(), we then call zpool_stats_refresh()
again for our handle on the same pool.

All together, this means we're doing two ZFS_IOC_POOL_STATS calls into
the kernel for every pool in the system. This isn't wrong, but it does
double the pressure on global locks.

Instead, we add a new function zpool_refresh_stats_from_handle() that
simply copies the pool config and state from one handle to another, and
use it to update our handle before we release it in add_pool(), so we
only have one call per pool per interval.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
Closes #17807
2025-10-21 09:50:43 -07:00
..
compatibility.d Update compatibility.d files 2025-09-09 17:04:01 -07:00
os GCC 15: Fix unterminated-string-initialization (#17244) 2025-04-16 09:33:29 -07:00
zpool.d zed: misc vdev_enc_sysfs_path fixes 2023-11-07 09:09:24 -08:00
Makefile.am Update compatibility.d files 2025-09-09 17:04:01 -07:00
zpool_iter.c pool_iter_refresh: don't refresh pools twice 2025-10-21 09:50:43 -07:00
zpool_main.c zpool iostat: update pool counter when skipping boot row 2025-10-21 09:50:43 -07:00
zpool_util.c SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
zpool_util.h zpool iostat: refresh pool list every interval 2025-09-29 16:50:49 -07:00
zpool_vdev.c Fix 'zpool add' safety check corner cases 2025-09-25 12:08:09 -07:00