mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-18 02:20:59 +03:00
baa40d45cb
It turns out that 'zpool events' over 1024 bytes in size where being silently dropped. This was discovered while writing the zfault.sh tests to validate common failure modes. This could occur because the zfs interface for passing an arbitrary size nvlist_t over an ioctl() is to provide a buffer for the packed nvlist which is usually big enough. In this case 1024 byte is the default. If the kernel determines the buffer is to small it returns ENOMEM and the minimum required size of the nvlist_t. This was working properly but in the case of 'zpool events' the event stream was advanced dispite the error. Thus the retry with the bigger buffer would succeed but it would skip over the previous event. The fix is to pass this size to zfs_zevent_next() and determine before removing the event from the list if it will fit. This was preferable to checking after the event was returned because this avoids the need to rewind the stream.
116 lines
3.4 KiB
C
116 lines
3.4 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
|
|
/*
|
|
* Copyright (c) 2004, 2010, Oracle and/or its affiliates. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _SYS_FM_UTIL_H
|
|
#define _SYS_FM_UTIL_H
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
#include <sys/nvpair.h>
|
|
|
|
/*
|
|
* Shared user/kernel definitions for class length, error channel name,
|
|
* and kernel event publisher string.
|
|
*/
|
|
#define FM_MAX_CLASS 100
|
|
#define FM_ERROR_CHAN "com.sun:fm:error"
|
|
#define FM_PUB "fm"
|
|
|
|
/*
|
|
* ereport dump device transport support
|
|
*
|
|
* Ereports are written out to the dump device at a proscribed offset from the
|
|
* end, similar to in-transit log messages. The ereports are represented as a
|
|
* erpt_dump_t header followed by ed_size bytes of packed native nvlist data.
|
|
*
|
|
* NOTE: All of these constants and the header must be defined so they have the
|
|
* same representation for *both* 32-bit and 64-bit producers and consumers.
|
|
*/
|
|
#define ERPT_MAGIC 0xf00d4eddU
|
|
#define ERPT_MAX_ERRS 16
|
|
#define ERPT_DATA_SZ (6 * 1024)
|
|
#define ERPT_EVCH_MAX 256
|
|
#define ERPT_HIWAT 64
|
|
|
|
typedef struct erpt_dump {
|
|
uint32_t ed_magic; /* ERPT_MAGIC or zero to indicate end */
|
|
uint32_t ed_chksum; /* checksum32() of packed nvlist data */
|
|
uint32_t ed_size; /* ereport (nvl) fixed buf size */
|
|
uint32_t ed_pad; /* reserved for future use */
|
|
hrtime_t ed_hrt_nsec; /* hrtime of this ereport */
|
|
hrtime_t ed_hrt_base; /* hrtime sample corresponding to ed_tod_base */
|
|
struct {
|
|
uint64_t sec; /* seconds since gettimeofday() Epoch */
|
|
uint64_t nsec; /* nanoseconds past ed_tod_base.sec */
|
|
} ed_tod_base;
|
|
} erpt_dump_t;
|
|
|
|
#ifdef _KERNEL
|
|
|
|
#define ZEVENT_SHUTDOWN 0x1
|
|
|
|
typedef void zevent_cb_t(nvlist_t *, nvlist_t *);
|
|
|
|
typedef struct zevent_s {
|
|
nvlist_t *ev_nvl; /* protected by the zevent_lock */
|
|
nvlist_t *ev_detector; /* " */
|
|
list_t ev_ze_list; /* " */
|
|
list_node_t ev_node; /* " */
|
|
zevent_cb_t *ev_cb; /* " */
|
|
} zevent_t;
|
|
|
|
typedef struct zfs_zevent {
|
|
zevent_t *ze_zevent; /* protected by the zevent_lock */
|
|
list_node_t ze_node; /* " */
|
|
uint64_t ze_dropped; /* " */
|
|
} zfs_zevent_t;
|
|
|
|
extern void fm_init(void);
|
|
extern void fm_fini(void);
|
|
extern void fm_nvprint(nvlist_t *);
|
|
extern void zfs_zevent_post(nvlist_t *, nvlist_t *, zevent_cb_t *);
|
|
extern void zfs_zevent_drain_all(int *);
|
|
extern int zfs_zevent_fd_hold(int, minor_t *, zfs_zevent_t **);
|
|
extern void zfs_zevent_fd_rele(int);
|
|
extern int zfs_zevent_next(zfs_zevent_t *, nvlist_t **, uint64_t *, uint64_t *);
|
|
extern int zfs_zevent_wait(zfs_zevent_t *);
|
|
extern void zfs_zevent_init(zfs_zevent_t **);
|
|
extern void zfs_zevent_destroy(zfs_zevent_t *);
|
|
|
|
#else
|
|
|
|
static inline void fm_init(void) { }
|
|
static inline void fm_fini(void) { }
|
|
|
|
#endif /* _KERNEL */
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
#endif /* _SYS_FM_UTIL_H */
|