mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2025-01-12 19:20:28 +03:00
a51288aabb
Coverity caught unsafe use of `strcpy()` in `ztest_dmu_objset_own()`, `nfs_init_tmpfile()` and `dump_snapshot()`. It also caught an unsafe use of `strlcat()` in `nfs_init_tmpfile()`. Inspired by this, I did an audit of every single usage of `strcpy()` and `strcat()` in the code. If I could not prove that the usage was safe, I changed the code to use either `strlcpy()` or `strlcat()`, depending on which function was originally used. In some cases, `snprintf()` was used to replace multiple uses of `strcat` because it was cleaner. Whenever I changed a function, I preferred to use `sizeof(dst)` when the compiler is able to provide the string size via that. When it could not because the string was passed by a caller, I checked the entire call tree of the function to find out how big the buffer was and hard coded it. Hardcoding is less than ideal, but it is safe unless someone shrinks the buffer sizes being passed. Additionally, Coverity reported three more string related issues: * It caught a case where we do an overlapping memory copy in a call to `snprintf()`. We fix that via `kmem_strdup()` and `kmem_strfree()`. * It caught `sizeof (buf)` being used instead of `buflen` in `zdb_nicenum()`'s call to `zfs_nicenum()`, which is passed to `snprintf()`. We change that to pass `buflen`. * It caught a theoretical unterminated string passed to `strcmp()`. This one is likely a false positive, but we have the information needed to do this more safely, so we change this to silence the false positive not just in coverity, but potentially other static analysis tools too. We switch to `strncmp()`. * There was a false positive in tests/zfs-tests/cmd/dir_rd_update.c. We suppress it by switching to `snprintf()` since other static analysis tools might complain about it too. Interestingly, there is a possible real bug there too, since it assumes that the passed directory path ends with '/'. We add a '/' to fix that potential bug. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13913 |
||
|---|---|---|
| .. | ||
| checksum | ||
| file | ||
| linux_dos_attributes | ||
| .gitignore | ||
| badsend.c | ||
| btree_test.c | ||
| chg_usr_exec.c | ||
| cp_files.c | ||
| ctime.c | ||
| devname2devid.c | ||
| dir_rd_update.c | ||
| dosmode_readonly_write.c | ||
| draid.c | ||
| ereports.c | ||
| get_diff.c | ||
| getversion.c | ||
| libzfs_input_check.c | ||
| Makefile.am | ||
| mkbusy.c | ||
| mkfile.c | ||
| mkfiles.c | ||
| mktree.c | ||
| mmap_exec.c | ||
| mmap_libaio.c | ||
| mmap_seek.c | ||
| mmap_sync.c | ||
| mmapwrite.c | ||
| nvlist_to_lua.c | ||
| readmmap.c | ||
| rename_dir.c | ||
| rm_lnkcnt_zero_file.c | ||
| send_doall.c | ||
| stride_dd.c | ||
| suid_write_to_file.c | ||
| threadsappend.c | ||
| truncate_test.c | ||
| user_ns_exec.c | ||
| xattrtest.c | ||
| zed_fd_spill-zedlet.c | ||
| zfs_diff-socket.c | ||