mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-26 03:09:34 +03:00
2a493a4c71
Coverity complained about unchecked return values and unused values that turned out to be unused return values. Different approaches were used to handle the different cases of unchecked return values: * cmd/zdb/zdb.c: VERIFY0 was used in one place since the existing code had no error handling. An error message was printed in another to match the rest of the code. * cmd/zed/agents/zfs_retire.c: We dismiss the return value with `(void)` because the value is expected to be potentially unset. * cmd/zpool_influxdb/zpool_influxdb.c: We dismiss the return value with `(void)` because the values are expected to be potentially unset. * cmd/ztest.c: VERIFY0 was used since we want failures if something goes wrong in ztest. * module/zfs/dsl_dir.c: We dismiss the return value with `(void)` because there is no guarantee that the zap entry will always be there. For example, old pools imported readonly would not have it and we do not want to fail here because of that. * module/zfs/zfs_fm.c: `fnvlist_add_*()` was used since the allocations sleep and thus can never fail. * module/zfs/zvol.c: We dismiss the return value with `(void)` because we do not need it. This matches what is already done in the analogous `zfs_replay_write2()`. * tests/zfs-tests/cmd/draid.c: We suppress one return value with `(void)` since the code handles errors already. The other return value is handled by switching to `fnvlist_lookup_uint8_array()`. * tests/zfs-tests/cmd/file/file_fadvise.c: We add error handling. * tests/zfs-tests/cmd/mmap_sync.c: We add error handling for munmap, but ignore failures on remove() with (void) since it is expected to be able to fail. * tests/zfs-tests/cmd/mmapwrite.c: We add error handling. As for unused return values, they were all in places where there was error handling, so logic was added to handle the return values. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13920
165 lines
3.5 KiB
C
165 lines
3.5 KiB
C
/*
|
|
* This file and its contents are supplied under the terms of the
|
|
* Common Development and Distribution License ("CDDL"), version 1.0.
|
|
* You may only use this file in accordance with the terms of version
|
|
* 1.0 of the CDDL.
|
|
*
|
|
* A full copy of the text of the CDDL should have accompanied this
|
|
* source. A copy of the CDDL is also available via the Internet at
|
|
* http://www.illumos.org/license/CDDL.
|
|
*/
|
|
/*
|
|
* Copyright 2020 Toomas Soome <tsoome@me.com>
|
|
*/
|
|
|
|
#include <sys/types.h>
|
|
#include <string.h>
|
|
#include <libzfs.h>
|
|
#include <libzfsbootenv.h>
|
|
#include <sys/zfs_bootenv.h>
|
|
#include <sys/vdev_impl.h>
|
|
|
|
/*
|
|
* Store device name to zpool label bootenv area.
|
|
* This call will set bootenv version to VB_NVLIST, if bootenv currently
|
|
* does contain other version, then old data will be replaced.
|
|
*/
|
|
int
|
|
lzbe_set_boot_device(const char *pool, lzbe_flags_t flag, const char *device)
|
|
{
|
|
libzfs_handle_t *hdl;
|
|
zpool_handle_t *zphdl;
|
|
nvlist_t *nv;
|
|
char *descriptor;
|
|
uint64_t version;
|
|
int rv = -1;
|
|
|
|
if (pool == NULL || *pool == '\0')
|
|
return (rv);
|
|
|
|
if ((hdl = libzfs_init()) == NULL)
|
|
return (rv);
|
|
|
|
zphdl = zpool_open(hdl, pool);
|
|
if (zphdl == NULL) {
|
|
libzfs_fini(hdl);
|
|
return (rv);
|
|
}
|
|
|
|
switch (flag) {
|
|
case lzbe_add:
|
|
rv = zpool_get_bootenv(zphdl, &nv);
|
|
if (rv == 0) {
|
|
/*
|
|
* We got the nvlist, check for version.
|
|
* if version is missing or is not VB_NVLIST,
|
|
* create new list.
|
|
*/
|
|
rv = nvlist_lookup_uint64(nv, BOOTENV_VERSION,
|
|
&version);
|
|
if (rv == 0 && version == VB_NVLIST)
|
|
break;
|
|
|
|
/* Drop this nvlist */
|
|
fnvlist_free(nv);
|
|
}
|
|
zfs_fallthrough;
|
|
case lzbe_replace:
|
|
nv = fnvlist_alloc();
|
|
break;
|
|
default:
|
|
return (rv);
|
|
}
|
|
|
|
/* version is mandatory */
|
|
fnvlist_add_uint64(nv, BOOTENV_VERSION, VB_NVLIST);
|
|
|
|
rv = 0;
|
|
/*
|
|
* If device name is empty, remove boot device configuration.
|
|
*/
|
|
if ((device == NULL || *device == '\0')) {
|
|
if (nvlist_exists(nv, OS_BOOTONCE))
|
|
fnvlist_remove(nv, OS_BOOTONCE);
|
|
} else {
|
|
/*
|
|
* Use device name directly if it does start with
|
|
* prefix "zfs:". Otherwise, add prefix and suffix.
|
|
*/
|
|
if (strncmp(device, "zfs:", 4) == 0) {
|
|
fnvlist_add_string(nv, OS_BOOTONCE, device);
|
|
} else {
|
|
if (asprintf(&descriptor, "zfs:%s:", device) > 0) {
|
|
fnvlist_add_string(nv, OS_BOOTONCE, descriptor);
|
|
free(descriptor);
|
|
} else
|
|
rv = ENOMEM;
|
|
}
|
|
}
|
|
if (rv == 0)
|
|
rv = zpool_set_bootenv(zphdl, nv);
|
|
if (rv != 0)
|
|
fprintf(stderr, "%s\n", libzfs_error_description(hdl));
|
|
|
|
fnvlist_free(nv);
|
|
zpool_close(zphdl);
|
|
libzfs_fini(hdl);
|
|
return (rv);
|
|
}
|
|
|
|
/*
|
|
* Return boot device name from bootenv, if set.
|
|
*/
|
|
int
|
|
lzbe_get_boot_device(const char *pool, char **device)
|
|
{
|
|
libzfs_handle_t *hdl;
|
|
zpool_handle_t *zphdl;
|
|
nvlist_t *nv;
|
|
char *val;
|
|
int rv = -1;
|
|
|
|
if (pool == NULL || *pool == '\0' || device == NULL)
|
|
return (rv);
|
|
|
|
if ((hdl = libzfs_init()) == NULL)
|
|
return (rv);
|
|
|
|
zphdl = zpool_open(hdl, pool);
|
|
if (zphdl == NULL) {
|
|
libzfs_fini(hdl);
|
|
return (rv);
|
|
}
|
|
|
|
rv = zpool_get_bootenv(zphdl, &nv);
|
|
if (rv == 0) {
|
|
rv = nvlist_lookup_string(nv, OS_BOOTONCE, &val);
|
|
if (rv == 0) {
|
|
/*
|
|
* zfs device descriptor is in form of "zfs:dataset:",
|
|
* we only do need dataset name.
|
|
*/
|
|
if (strncmp(val, "zfs:", 4) == 0) {
|
|
val += 4;
|
|
val = strdup(val);
|
|
if (val != NULL) {
|
|
size_t len = strlen(val);
|
|
|
|
if (val[len - 1] == ':')
|
|
val[len - 1] = '\0';
|
|
*device = val;
|
|
} else {
|
|
rv = ENOMEM;
|
|
}
|
|
} else {
|
|
rv = EINVAL;
|
|
}
|
|
}
|
|
nvlist_free(nv);
|
|
}
|
|
|
|
zpool_close(zphdl);
|
|
libzfs_fini(hdl);
|
|
return (rv);
|
|
}
|