Pawel Jakub Dawidek 3d244b4881 Fix clearing set-uid and set-gid bits on a file when replying a write ... POSIX requires that set-uid and set-gid bits to be removed when an unprivileged user writes to a file and ZFS does that during normal operation. The problem arrises when the write is stored in the ZIL and replayed. During replay we have no access to original credentials of the process doing the write, so zfs_write() will be performed with the root credentials. When root is doing the write set-uid and set-gid bits are not removed from the file. To correct that, log a separate TX_SETATTR entry that removed those bits on first write to such file. Idea from: Christian Schwarz Add test for ZIL replay of setuid/setgid clearing. Improve various edge cases when clearing setid bits: - The setid bits can be readded during a single write, so make sure to check for them on every chunk write. - Log TX_SETATTR record at most once per transaction group (if the setid bits are keep coming back). - Move zfs_log_setattr() outside of zp->z_acl_lock. Reviewed-by: Dan McDonald <danmcd@joyent.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Co-authored-by: Christian Schwarz <me@cschwarz.com> Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net> Closes #13027		2022-02-03 14:37:57 -08:00
..
callbacks	ZTS: Add a failsafe callback to run after each test	2020-03-10 11:00:56 -07:00
cmd	Fix trivial calloc(3) arguments order	2022-02-02 11:27:35 -08:00
include	Add --enable-asan and --enable-ubsan switches	2022-02-03 14:35:38 -08:00
tests	Fix clearing set-uid and set-gid bits on a file when replying a write	2022-02-03 14:37:57 -08:00
Makefile.am	OpenZFS 7503 - zfs-test should tail ::zfs_dbgmsg on test failure	2017-04-12 13:36:48 -07:00