mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-18 02:20:59 +03:00
2e7f664f04
I recently gained the ability to run Clang's static analyzer on the linux kernel modules via a few hacks. This extended coverage to code that was previously missed since Clang's static analyzer only looked at code that we built in userspace. Running it against the Linux kernel modules built from my local branch produced a total of 72 reports against my local branch. Of those, 50 were reports of logic errors and 22 were reports of dead code. Since we already had cleaned up all of the previous dead code reports, I felt it would be a good next step to clean up these dead code reports. Clang did a further breakdown of the dead code reports into: Dead assignment 15 Dead increment 2 Dead nested assignment 5 The benefit of cleaning these up, especially in the case of dead nested assignment, is that they can expose places where our error handling is incorrect. A number of them were fairly straight forward. However several were not: In vdev_disk_physio_completion(), not only were we not using the return value from the static function vdev_disk_dio_put(), but nothing used it, so I changed it to return void and removed the existing (void) cast in the other area where we call it in addition to no longer storing it to a stack value. In FSE_createDTable(), the function is dead code. Its helper function FSE_freeDTable() is also dead code, as are the CPP definitions in `module/zstd/include/zstd_compat_wrapper.h`. We just delete it all. In zfs_zevent_wait(), we have an optimization opportunity. cv_wait_sig() returns 0 if there are waiting signals and 1 if there are none. The Linux SPL version literally returns `signal_pending(current) ? 0 : 1)` and FreeBSD implements the same semantics, we can just do `!cv_wait_sig()` in place of `signal_pending(current)` to avoid unnecessarily calling it again. zfs_setattr() on FreeBSD version did not have error handling issue because the code was removed entirely from FreeBSD version. The error is from updating the attribute directory's files. After some thought, I decided to propapage errors on it to userspace. In zfs_secpolicy_tmp_snapshot(), we ignore a lack of permission from the first check in favor of checking three other permissions. I assume this is intentional. In zfs_create_fs(), the return value of zap_update() was not checked despite setting an important version number. I see no backward compatibility reason to permit failures, so we add an assertion to catch failures. Interestingly, Linux is still using ASSERT(error == 0) from OpenSolaris while FreeBSD has switched to the improved ASSERT0(error) from illumos, although illumos has yet to adopt it here. ASSERT(error == 0) was used on Linux while ASSERT0(error) was used on FreeBSD since the entire file needs conversion and that should be the subject of another patch. dnode_move()'s issue was caused by us not having implemented POINTER_IS_VALID() on Linux. We have a stub in `include/os/linux/spl/sys/kmem_cache.h` for it, when it really should be in `include/os/linux/spl/sys/kmem.h` to be consistent with Illumos/OpenSolaris. FreeBSD put both `POINTER_IS_VALID()` and `POINTER_INVALIDATE()` in `include/os/freebsd/spl/sys/kmem.h`, so we copy what it did. Whenever a report was in platform-specific code, I checked the FreeBSD version to see if it also applied to FreeBSD, but it was only relevant a few times. Lastly, the patch that enabled Clang's static analyzer to be run on the Linux kernel modules needs more work before it can be put into a PR. I plan to do that in the future as part of the on-going static analysis work that I am doing. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #14380
220 lines
6.4 KiB
C
220 lines
6.4 KiB
C
/*
|
|
* Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
|
|
* Copyright (C) 2007 The Regents of the University of California.
|
|
* Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
|
|
* Written by Brian Behlendorf <behlendorf1@llnl.gov>.
|
|
* UCRL-CODE-235197
|
|
*
|
|
* This file is part of the SPL, Solaris Porting Layer.
|
|
*
|
|
* The SPL is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* The SPL is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with the SPL. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef _SPL_KMEM_H
|
|
#define _SPL_KMEM_H
|
|
|
|
#include <sys/debug.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/vmalloc.h>
|
|
|
|
extern int kmem_debugging(void);
|
|
extern char *kmem_vasprintf(const char *fmt, va_list ap)
|
|
__attribute__((format(printf, 1, 0)));
|
|
extern char *kmem_asprintf(const char *fmt, ...)
|
|
__attribute__((format(printf, 1, 2)));
|
|
extern char *kmem_strdup(const char *str);
|
|
extern void kmem_strfree(char *str);
|
|
|
|
#define kmem_scnprintf scnprintf
|
|
|
|
#define POINTER_IS_VALID(p) (!((uintptr_t)(p) & 0x3))
|
|
#define POINTER_INVALIDATE(pp) (*(pp) = (void *)((uintptr_t)(*(pp)) | 0x1))
|
|
|
|
/*
|
|
* Memory allocation interfaces
|
|
*/
|
|
#define KM_SLEEP 0x0000 /* can block for memory; success guaranteed */
|
|
#define KM_NOSLEEP 0x0001 /* cannot block for memory; may fail */
|
|
#define KM_PUSHPAGE 0x0004 /* can block for memory; may use reserve */
|
|
#define KM_ZERO 0x1000 /* zero the allocation */
|
|
#define KM_VMEM 0x2000 /* caller is vmem_* wrapper */
|
|
|
|
#define KM_PUBLIC_MASK (KM_SLEEP | KM_NOSLEEP | KM_PUSHPAGE)
|
|
|
|
static int spl_fstrans_check(void);
|
|
void *spl_kvmalloc(size_t size, gfp_t flags);
|
|
|
|
/*
|
|
* Convert a KM_* flags mask to its Linux GFP_* counterpart. The conversion
|
|
* function is context aware which means that KM_SLEEP allocations can be
|
|
* safely used in syncing contexts which have set PF_FSTRANS.
|
|
*/
|
|
static inline gfp_t
|
|
kmem_flags_convert(int flags)
|
|
{
|
|
gfp_t lflags = __GFP_NOWARN | __GFP_COMP;
|
|
|
|
if (flags & KM_NOSLEEP) {
|
|
lflags |= GFP_ATOMIC | __GFP_NORETRY;
|
|
} else {
|
|
lflags |= GFP_KERNEL;
|
|
if (spl_fstrans_check())
|
|
lflags &= ~(__GFP_IO|__GFP_FS);
|
|
}
|
|
|
|
if (flags & KM_PUSHPAGE)
|
|
lflags |= __GFP_HIGH;
|
|
|
|
if (flags & KM_ZERO)
|
|
lflags |= __GFP_ZERO;
|
|
|
|
return (lflags);
|
|
}
|
|
|
|
typedef struct {
|
|
struct task_struct *fstrans_thread;
|
|
unsigned int saved_flags;
|
|
} fstrans_cookie_t;
|
|
|
|
/*
|
|
* Introduced in Linux 3.9, however this cannot be solely relied on before
|
|
* Linux 3.18 as it doesn't turn off __GFP_FS as it should.
|
|
*/
|
|
#ifdef PF_MEMALLOC_NOIO
|
|
#define __SPL_PF_MEMALLOC_NOIO (PF_MEMALLOC_NOIO)
|
|
#else
|
|
#define __SPL_PF_MEMALLOC_NOIO (0)
|
|
#endif
|
|
|
|
/*
|
|
* PF_FSTRANS is removed from Linux 4.12
|
|
*/
|
|
#ifdef PF_FSTRANS
|
|
#define __SPL_PF_FSTRANS (PF_FSTRANS)
|
|
#else
|
|
#define __SPL_PF_FSTRANS (0)
|
|
#endif
|
|
|
|
#define SPL_FSTRANS (__SPL_PF_FSTRANS|__SPL_PF_MEMALLOC_NOIO)
|
|
|
|
static inline fstrans_cookie_t
|
|
spl_fstrans_mark(void)
|
|
{
|
|
fstrans_cookie_t cookie;
|
|
|
|
BUILD_BUG_ON(SPL_FSTRANS == 0);
|
|
|
|
cookie.fstrans_thread = current;
|
|
cookie.saved_flags = current->flags & SPL_FSTRANS;
|
|
current->flags |= SPL_FSTRANS;
|
|
|
|
return (cookie);
|
|
}
|
|
|
|
static inline void
|
|
spl_fstrans_unmark(fstrans_cookie_t cookie)
|
|
{
|
|
ASSERT3P(cookie.fstrans_thread, ==, current);
|
|
ASSERT((current->flags & SPL_FSTRANS) == SPL_FSTRANS);
|
|
|
|
current->flags &= ~SPL_FSTRANS;
|
|
current->flags |= cookie.saved_flags;
|
|
}
|
|
|
|
static inline int
|
|
spl_fstrans_check(void)
|
|
{
|
|
return (current->flags & SPL_FSTRANS);
|
|
}
|
|
|
|
/*
|
|
* specifically used to check PF_FSTRANS flag, cannot be relied on for
|
|
* checking spl_fstrans_mark().
|
|
*/
|
|
static inline int
|
|
__spl_pf_fstrans_check(void)
|
|
{
|
|
return (current->flags & __SPL_PF_FSTRANS);
|
|
}
|
|
|
|
/*
|
|
* Kernel compatibility for GFP flags
|
|
*/
|
|
/* < 4.13 */
|
|
#ifndef __GFP_RETRY_MAYFAIL
|
|
#define __GFP_RETRY_MAYFAIL __GFP_REPEAT
|
|
#endif
|
|
/* < 4.4 */
|
|
#ifndef __GFP_RECLAIM
|
|
#define __GFP_RECLAIM __GFP_WAIT
|
|
#endif
|
|
|
|
#ifdef HAVE_ATOMIC64_T
|
|
#define kmem_alloc_used_add(size) atomic64_add(size, &kmem_alloc_used)
|
|
#define kmem_alloc_used_sub(size) atomic64_sub(size, &kmem_alloc_used)
|
|
#define kmem_alloc_used_read() atomic64_read(&kmem_alloc_used)
|
|
#define kmem_alloc_used_set(size) atomic64_set(&kmem_alloc_used, size)
|
|
extern atomic64_t kmem_alloc_used;
|
|
extern unsigned long long kmem_alloc_max;
|
|
#else /* HAVE_ATOMIC64_T */
|
|
#define kmem_alloc_used_add(size) atomic_add(size, &kmem_alloc_used)
|
|
#define kmem_alloc_used_sub(size) atomic_sub(size, &kmem_alloc_used)
|
|
#define kmem_alloc_used_read() atomic_read(&kmem_alloc_used)
|
|
#define kmem_alloc_used_set(size) atomic_set(&kmem_alloc_used, size)
|
|
extern atomic_t kmem_alloc_used;
|
|
extern unsigned long long kmem_alloc_max;
|
|
#endif /* HAVE_ATOMIC64_T */
|
|
|
|
extern unsigned int spl_kmem_alloc_warn;
|
|
extern unsigned int spl_kmem_alloc_max;
|
|
|
|
#define kmem_alloc(sz, fl) spl_kmem_alloc((sz), (fl), __func__, __LINE__)
|
|
#define kmem_zalloc(sz, fl) spl_kmem_zalloc((sz), (fl), __func__, __LINE__)
|
|
#define kmem_free(ptr, sz) spl_kmem_free((ptr), (sz))
|
|
#define kmem_cache_reap_active spl_kmem_cache_reap_active
|
|
|
|
extern void *spl_kmem_alloc(size_t sz, int fl, const char *func, int line)
|
|
__attribute__((alloc_size(1)));
|
|
extern void *spl_kmem_zalloc(size_t sz, int fl, const char *func, int line)
|
|
__attribute__((alloc_size(1)));
|
|
extern void spl_kmem_free(const void *ptr, size_t sz);
|
|
|
|
/*
|
|
* 5.8 API change, pgprot_t argument removed.
|
|
*/
|
|
#ifdef HAVE_VMALLOC_PAGE_KERNEL
|
|
#define spl_vmalloc(size, flags) __vmalloc(size, flags, PAGE_KERNEL)
|
|
#else
|
|
#define spl_vmalloc(size, flags) __vmalloc(size, flags)
|
|
#endif
|
|
|
|
/*
|
|
* The following functions are only available for internal use.
|
|
*/
|
|
extern void *spl_kmem_alloc_impl(size_t size, int flags, int node);
|
|
extern void *spl_kmem_alloc_debug(size_t size, int flags, int node);
|
|
extern void *spl_kmem_alloc_track(size_t size, int flags,
|
|
const char *func, int line, int node);
|
|
extern void spl_kmem_free_impl(const void *buf, size_t size);
|
|
extern void spl_kmem_free_debug(const void *buf, size_t size);
|
|
extern void spl_kmem_free_track(const void *buf, size_t size);
|
|
|
|
extern int spl_kmem_init(void);
|
|
extern void spl_kmem_fini(void);
|
|
extern int spl_kmem_cache_reap_active(void);
|
|
|
|
#endif /* _SPL_KMEM_H */
|