mirror_zfs/module/nvpair
Richard Yao 27ff18cd43 Fix possible NULL pointer dereference in nvlist_lookup_nvpair_ei_sep()
Clang's static analyzer complains about a possible NULL pointer
dereference in nvlist_lookup_nvpair_ei_sep() because it unconditionally
dereferences a pointer initialized by `nvpair_value_nvlist_array()`
under the assumption that `nvpair_value_nvlist_array()` will always
initialize the pointer without checking to see if an error was returned
to indicate otherwise. This itself is improper error handling, so we fix
it. However, fixing it to properly respond to errors is not enough to
avoid a NULL pointer dereference, since we can receive NULL when the
array is empty, so we also add a NULL check.

Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14612
2023-03-14 15:25:35 -07:00
..
fnvpair.c Replace dead opensolaris.org license link 2022-07-11 14:16:13 -07:00
nvpair_alloc_fixed.c Replace dead opensolaris.org license link 2022-07-11 14:16:13 -07:00
nvpair_alloc_spl.c Replace dead opensolaris.org license link 2022-07-11 14:16:13 -07:00
nvpair.c Fix possible NULL pointer dereference in nvlist_lookup_nvpair_ei_sep() 2023-03-14 15:25:35 -07:00