mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-18 10:21:01 +03:00
1f5979d23f
zed core dumps due to a NULL pointer in zfs_agent_iter_vdev(). The gs_devid is NULL, but the nvl has a "devid" entry. zfs_agent_post_event() checks that ZFS_EV_VDEV_GUID or DEV_IDENTIFIER is present in nvl, but then later it and zfs_agent_iter_vdev() assume that DEV_IDENTIFIER is present and thus gs_devid is set. Typically this is not a problem because usually either all vdevs have devid's, or none of them do. Since zfs_agent_iter_vdev() first checks if the vdev has devid before dereferencing gs_devid, the problem isn't typically encountered. However, if some vdevs have devid's and some do not, then the problem is easily reproduced. This can happen if the pool has been moved from a system that has devid's to one that does not. The fix is for zfs_agent_iter_vdev() to only try to match the devid's if both nvl and gsp have devid's present. Reviewed-by: Prashanth Sreenivasa <pks@delphix.com> Reviewed-by: Don Brady <don.brady@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: loli10K <ezomori.nozomu@gmail.com> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> External-issue: DLPX-65090 Closes #9054 Closes #9060 |
||
|---|---|---|
| .. | ||
| agents | ||
| zed.d | ||
| .gitignore | ||
| Makefile.am | ||
| zed_conf.c | ||
| zed_conf.h | ||
| zed_disk_event.c | ||
| zed_disk_event.h | ||
| zed_event.c | ||
| zed_event.h | ||
| zed_exec.c | ||
| zed_exec.h | ||
| zed_file.c | ||
| zed_file.h | ||
| zed_log.c | ||
| zed_log.h | ||
| zed_strings.c | ||
| zed_strings.h | ||
| zed.c | ||
| zed.h | ||