mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-26 19:19:32 +03:00
e843553d03
If a thread is holding mutex when doing cv_destroy, it might end up waiting a thread in cv_wait. The waiter would wake up trying to aquire the same mutex and cause deadlock. We solve this by move the mutex_enter to the bottom of cv_wait, so that the waiter will release the cv first, allowing cv_destroy to succeed and have a chance to free the mutex. This would create race condition on the cv_mutex. We use xchg to set and check it to ensure we won't be harmed by the race. This would result in the cv_mutex debugging becomes best-effort. Also, the change reveals a race, which was unlikely before, where we call mutex_destroy while test threads are still holding the mutex. We use kthread_stop to make sure the threads are exit before mutex_destroy. Signed-off-by: Chunwei Chen <tuxoko@gmail.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Tim Chase <tim@chase2k.com> Issue zfsonlinux/zfs#4166 Issue zfsonlinux/zfs#4106 |
||
|---|---|---|
| .. | ||
| Makefile.in | ||
| splat-atomic.c | ||
| splat-condvar.c | ||
| splat-cred.c | ||
| splat-ctl.c | ||
| splat-generic.c | ||
| splat-internal.h | ||
| splat-kmem.c | ||
| splat-kobj.c | ||
| splat-linux.c | ||
| splat-list.c | ||
| splat-mutex.c | ||
| splat-random.c | ||
| splat-rwlock.c | ||
| splat-taskq.c | ||
| splat-thread.c | ||
| splat-time.c | ||
| splat-vnode.c | ||
| splat-zlib.c | ||