Matthew Ahrens
08dc1b2ddd
Illumos 5350 - clean up code in dnode_sync()
...
Author: Matthew Ahrens <mahrens@delphix.com >
Reviewed by: Alex Reece <alex.reece@delphix.com >
Reviewed by: Christopher Siden <christopher.siden@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Richard Elling <richard.elling@richardelling.com >
Approved by: Dan McDonald <danmcd@omniti.com >
References:
https://www.illumos.org/issues/5350
https://github.com/illumos/illumos-gate/commit/e651831
Ported-by: Chris Dunlop <chris@onthe.net.au >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #3382
2015-05-11 15:09:51 -07:00
Justin T. Gibbs
6ebebaceb1
Illumos 5531 - NULL pointer dereference in dsl_prop_get_ds()
...
5531 NULL pointer dereference in dsl_prop_get_ds()
Author: Justin T. Gibbs <justing@spectralogic.com >
Reviewed by: Matthew Ahrens <mahrens@delphix.com >
Reviewed by: Dan McDonald <danmcd@omniti.com >
Reviewed by: George Wilson <george@delphix.com >
Reviewed by: Bayard Bell <buffer.g.overflow@gmail.com >
Approved by: Robert Mustacchi <rm@joyent.com >
References:
https://www.illumos.org/issues/5531
https://github.com/illumos/illumos-gate/commit/e57a022
Ported-by: Chris Dunlop <chris@onthe.net.au >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
2015-04-28 16:25:44 -07:00
Justin T. Gibbs
0c66c32d1d
Illumos 5056 - ZFS deadlock on db_mtx and dn_holds
...
5056 ZFS deadlock on db_mtx and dn_holds
Author: Justin Gibbs <justing@spectralogic.com >
Reviewed by: Will Andrews <willa@spectralogic.com >
Reviewed by: Matt Ahrens <mahrens@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Approved by: Dan McDonald <danmcd@omniti.com >
References:
https://www.illumos.org/issues/5056
https://github.com/illumos/illumos-gate/commit/bc9014e
Porting Notes:
sa_handle_get_from_db():
- the original patch includes an otherwise unmentioned fix for a
possible usage of an uninitialised variable
dmu_objset_open_impl():
- Under Illumos list_link_init() is the same as filling a list_node_t
with NULLs, so they don't notice if they miss doing list_link_init()
on a zero'd containing structure (e.g. allocated with kmem_zalloc as
here). Under Linux, not so much: an uninitialised list_node_t goes
"Boom!" some time later when it's used or destroyed.
dmu_objset_evict_dbufs():
- reduce stack usage using kmem_alloc()
Ported-by: Chris Dunlop <chris@onthe.net.au >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
2015-04-28 16:25:34 -07:00
Alex Reece
8951cb8dfb
Illumos 4873 - zvol unmap calls can take a very long time for larger datasets
...
4873 zvol unmap calls can take a very long time for larger datasets
Author: Alex Reece <alex@delphix.com >
Reviewed by: George Wilson <george@delphix.com >
Reviewed by: Matthew Ahrens <mahrens@delphix.com >
Reviewed by: Paul Dagnelie <paul.dagnelie@delphix.com >
Reviewed by: Basil Crow <basil.crow@delphix.com >
Reviewed by: Dan McDonald <danmcd@omniti.com >
Approved by: Robert Mustacchi <rm@joyent.com >
References:
https://www.illumos.org/issues/4873
https://github.com/illumos/illumos-gate/commit/0f6d88a
Porting Notes:
dbuf_free_range():
- reduce stack usage using kmem_alloc()
- the sorted AVL tree will handle the spill block case correctly
without all the special handling in the for() loop
Ported-by: Chris Dunlop <chris@onthe.net.au >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
2015-04-28 16:24:03 -07:00
Jorgen Lundman
58c4aa00c6
Illumos 4975 - missing mutex_destroy() calls in zfs
...
4975 missing mutex_destroy() calls in zfs
Author: Jorgen Lundman <lundman@lundman.net >
Reviewed by: Matthew Ahrens <matthew.ahrens@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Rich Lowe <richlowe@richlowe.net >
Reviewed by: Seth Nimbosa <darth.Serious@gmail.com >
Reviewed by: Dan McDonald <danmcd@omniti.com >
Reviewed by: Don Brady <dev.fs.zfs@gmail.com >
Approved by: Dan McDonald <danmcd@omniti.com >
References:
https://www.illumos.org/issues/4975
https://github.com/illumos/illumos-gate/commit/d2b3cbb
Ported-by: Chris Dunlop <chris@onthe.net.au >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
2015-04-28 16:23:38 -07:00
Justin T. Gibbs
4c7b7eedcd
Illumos 5630 - stale bonus buffer in recycled dnode_t leads to data corruption
...
5630 stale bonus buffer in recycled dnode_t leads to data corruption
Author: Justin T. Gibbs <justing@spectralogic.com >
Reviewed by: Matthew Ahrens <mahrens@delphix.com >
Reviewed by: George Wilson <george@delphix.com >
Reviewed by: Will Andrews <will@freebsd.org >
Approved by: Robert Mustacchi <rm@joyent.com >
References:
https://www.illumos.org/issues/5630
https://github.com/illumos/illumos-gate/commit/cd485b4
Ported-by: Chris Dunlop <chris@onthe.net.au >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Richard Yao <ryao@gentoo.org >
Issue #3172
2015-03-12 15:40:39 -07:00
George Wilson
4f68d7878f
Illumos 5117 - spacemap reallocation can cause corruption
...
5117 space map reallocation can cause corruption
Reviewed by: Matthew Ahrens <mahrens@delphix.com >
Reviewed by: Sebastien Roy <sebastien.roy@delphix.com >
Reviewed by: Richard Elling <richard.elling@gmail.com >
Approved by: Richard Lowe <richlowe@richlowe.net >
References:
https://www.illumos.org/projects/illumos-gate/issues/5117
https://github.com/illumos/illumos-gate/commit/e503a68
Ported by: Turbo Fredriksson <turbo@bayour.com >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #2662
2014-09-08 09:42:39 -07:00
Matthew Ahrens
9b67f60560
Illumos 4757, 4913
...
4757 ZFS embedded-data block pointers ("zero block compression")
4913 zfs release should not be subject to space checks
Reviewed by: Adam Leventhal <ahl@delphix.com >
Reviewed by: Max Grossman <max.grossman@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Christopher Siden <christopher.siden@delphix.com >
Reviewed by: Dan McDonald <danmcd@omniti.com >
Approved by: Dan McDonald <danmcd@omniti.com >
References:
https://www.illumos.org/issues/4757
https://www.illumos.org/issues/4913
https://github.com/illumos/illumos-gate/commit/5d7b4d4
Porting notes:
For compatibility with the fastpath code the zio_done() function
needed to be updated. Because embedded-data block pointers do
not require DVAs to be allocated the associated vdevs will not
be marked and therefore should not be unmarked.
Ported by: Tim Chase <tim@chase2k.com >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #2544
2014-08-01 14:28:05 -07:00
Matthew Ahrens
9bd274ddd8
Illumos #4374
...
4374 dn_free_ranges should use range_tree_t
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Max Grossman <max.grossman@delphix.com >
Reviewed by: Christopher Siden <christopher.siden@delphix.com
Reviewed by: Garrett D'Amore <garrett@damore.org >
Reviewed by: Dan McDonald <danmcd@omniti.com >
Approved by: Dan McDonald <danmcd@omniti.com >
References:
https://www.illumos.org/issues/4374
https://github.com/illumos/illumos-gate/commit/bf16b11
Ported by: Tim Chase <tim@chase2k.com >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #2531
2014-07-30 09:20:35 -07:00
Max Grossman
b0bc7a84d9
Illumos 4370, 4371
...
4370 avoid transmitting holes during zfs send
4371 DMU code clean up
Reviewed by: Matthew Ahrens <mahrens@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Christopher Siden <christopher.siden@delphix.com >
Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net >
Approved by: Garrett D'Amore <garrett@damore.org >a
References:
https://www.illumos.org/issues/4370
https://www.illumos.org/issues/4371
https://github.com/illumos/illumos-gate/commit/43466aa
Ported by: Tim Chase <tim@chase2k.com >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #2529
2014-07-28 14:29:58 -07:00
Matthew Ahrens
fa86b5dbb6
Illumos 4171, 4172
...
4171 clean up spa_feature_*() interfaces
4172 implement extensible_dataset feature for use by other zpool features
Reviewed by: Max Grossman <max.grossman@delphix.com >
Reviewed by: Christopher Siden <christopher.siden@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com >
Approved by: Garrett D'Amore <garrett@damore.org >a
References:
https://www.illumos.org/issues/4171
https://www.illumos.org/issues/4172
https://github.com/illumos/illumos-gate/commit/2acef22
Ported-by: Tim Chase <tim@chase2k.com >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #2528
2014-07-25 16:40:07 -07:00
Will Andrews
d3cc8b152e
Illumos #3742
...
3742 zfs comments need cleaner, more consistent style
Reviewed by: Matthew Ahrens <mahrens@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Eric Schrock <eric.schrock@delphix.com >
Approved by: Christopher Siden <christopher.siden@delphix.com >
References:
https://www.illumos.org/issues/3742
illumos/illumos-gate@f717074149
Ported-by: Richard Yao <ryao@gentoo.org >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Issue #1775
Porting notes:
1. The change to zfs_vfsops.c was dropped because it involves
zfs_mount_label_policy, which does not exist in the Linux port.
2013-11-04 10:55:25 -08:00
Matthew Ahrens
13fe019870
Illumos #3464
...
3464 zfs synctask code needs restructuring
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com >
Reviewed by: Adam Leventhal <ahl@delphix.com >
Reviewed by: George Wilson <george.wilson@delphix.com >
Reviewed by: Christopher Siden <christopher.siden@delphix.com >
Approved by: Garrett D'Amore <garrett@damore.org >
References:
https://www.illumos.org/issues/3464
illumos/illumos-gate@3b2aab1880
Ported-by: Tim Chase <tim@chase2k.com >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #1495
2013-09-04 16:01:24 -07:00
Madhav Suresh
c99c90015e
Illumos #3006
...
3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first
argument is zero
Reviewed by Matt Ahrens <matthew.ahrens@delphix.com >
Reviewed by George Wilson <george.wilson@delphix.com >
Approved by Eric Schrock <eric.schrock@delphix.com >
References:
illumos/illumos-gate@fb09f5aad4
https://illumos.org/issues/3006
Requires:
zfsonlinux/spl@1c6d149feb
Ported-by: Tim Chase <tim@chase2k.com >
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #1509
2013-06-19 15:14:10 -07:00
Christopher Siden
9ae529ec5d
Illumos #2619 and #2747
...
2619 asynchronous destruction of ZFS file systems
2747 SPA versioning with zfs feature flags
Reviewed by: Matt Ahrens <mahrens@delphix.com >
Reviewed by: George Wilson <gwilson@delphix.com >
Reviewed by: Richard Lowe <richlowe@richlowe.net >
Reviewed by: Dan Kruchinin <dan.kruchinin@gmail.com >
Approved by: Eric Schrock <Eric.Schrock@delphix.com >
References:
illumos/illumos-gate@53089ab7c8
illumos/illumos-gate@ad135b5d64
illumos changeset: 13700:2889e2596bd6
https://www.illumos.org/issues/2619
https://www.illumos.org/issues/2747
NOTE: The grub specific changes were not ported. This change
must be made to the Linux grub packages.
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov >
2013-01-08 10:35:35 -08:00
Ned Bass
37f000c5aa
Fix gcc array subscript above bounds warning
...
In a debug build, certain GCC versions flag an array bounds warning in
the below code from dnode_sync.c
} else {
int i;
ASSERT(dn->dn_next_nblkptr[txgoff] < dnp->dn_nblkptr);
/* the blkptrs we are losing better be unallocated */
for (i = dn->dn_next_nblkptr[txgoff];
i < dnp->dn_nblkptr; i++)
ASSERT(BP_IS_HOLE(&dnp->dn_blkptr[i]));
This usage is in fact safe, since the ASSERT ensures the index does
not exceed to maximum possible number of block pointers. However gcc
can't determine that the assignment 'i = dn->dn_next_nblkptr[txgoff];'
falls within the array bounds so it issues a warning. To avoid this,
initialize i to zero to make gcc happy but skip the elements before
dn->dn_next_nblkptr[txgoff] in the loop body. Since a dnode contains
at most 3 block pointers this overhead should be negligible.
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
Closes #950
2013-01-07 11:21:52 -08:00
Brian Behlendorf
754c6663a3
Fix dbuf eviction assertion
...
Replace non-fatal assertion with warning. This was being observed
during testing and it should not be fatal.
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
2010-08-31 08:38:45 -07:00
Brian Behlendorf
1fde1e3720
Fix gcc unused variable warnings
...
Gcc -Wall warn: 'unused variable'
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
2010-08-31 08:38:43 -07:00
Brian Behlendorf
c65aa5b2b9
Fix gcc missing parenthesis warnings
...
Gcc -Wall warn: 'missing parenthesis'
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov >
2010-08-31 08:38:35 -07:00
Brian Behlendorf
572e285762
Update to onnv_147
...
This is the last official OpenSolaris tag before the public
development tree was closed.
2010-08-26 14:24:34 -07:00
Brian Behlendorf
428870ff73
Update core ZFS code from build 121 to build 141.
2010-05-28 13:45:14 -07:00
Brian Behlendorf
9babb37438
Rebase master to b117
2009-07-02 15:44:48 -07:00
Brian Behlendorf
d164b20935
Rebase master to b108
2009-02-18 12:51:31 -08:00
Brian Behlendorf
172bb4bd5e
Move the world out of /zfs/ and seperate out module build tree
2008-12-11 11:08:09 -08:00