0a9aaa7f0c
cmd: move single-file binaries up, extract udev programs to udev/
...
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Closes #13316
2022-05-10 10:20:34 -07:00
5cdca5b1da
autoconf: use include directives instead of recursing down cmd
...
No installation diff, dist lost
-zfs-2.1.99/cmd/fsck_zfs/fsck.zfs
which was distributed erroneously, since it's generated
Also clean gitrev on clean
Also add -e 'any possible bashisms' to default checkbashisms flags,
and fully parallelise it and shellcheck, and it works out-of-tree, too
Also align the Release in the dist META file correctly
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Closes #13316
2022-05-10 10:18:38 -07:00
c8970f52ed
autoconf: use include directives instead of recursing down lib
...
As a bonus, this also adds zfs-mount-generator (previously undescended
down) and libzstd (not included) to CppCheck
As a bonus bonus, abigail rules work out-of-tree, too
Against current trunk:
$ diff -U0 ./destdir.listing ~/store/code/zfs/destdir.listing
-destdir/usr/local/include/libspl/sscanf.h
$ diff --color -U0 ./zfs-2.1.99.tar.gz.listing ../oot/zfs-2.1.99.tar.gz.listing | grep -v @@ | grep -v /Makefile
-zfs-2.1.99/config/Abigail.am
-zfs-2.1.99/lib/libspl/include/util/
-zfs-2.1.99/lib/libspl/include/util/sscanf.h
$ diff --color -U0 ./zfs-2.1.99.tar.gz.listing ../oot/zfs-2.1.99.tar.gz.listing | grep -v @@ | grep /Makefile
-zfs-2.1.99/lib/libavl/Makefile.in
-zfs-2.1.99/lib/libefi/Makefile.in
-zfs-2.1.99/lib/libicp/Makefile.in
-zfs-2.1.99/lib/libnvpair/Makefile.in
-zfs-2.1.99/lib/libshare/Makefile.in
-zfs-2.1.99/lib/libspl/include/Makefile.in
-zfs-2.1.99/lib/libspl/include/os/freebsd/Makefile.am
-zfs-2.1.99/lib/libspl/include/os/freebsd/Makefile.in
-zfs-2.1.99/lib/libspl/include/os/freebsd/sys/Makefile.am
-zfs-2.1.99/lib/libspl/include/os/freebsd/sys/Makefile.in
-zfs-2.1.99/lib/libspl/include/os/linux/Makefile.am
-zfs-2.1.99/lib/libspl/include/os/linux/Makefile.in
-zfs-2.1.99/lib/libspl/include/os/linux/sys/Makefile.am
-zfs-2.1.99/lib/libspl/include/os/linux/sys/Makefile.in
-zfs-2.1.99/lib/libspl/include/os/Makefile.am
-zfs-2.1.99/lib/libspl/include/os/Makefile.in
-zfs-2.1.99/lib/libspl/include/rpc/Makefile.am
-zfs-2.1.99/lib/libspl/include/rpc/Makefile.in
-zfs-2.1.99/lib/libspl/include/sys/dktp/Makefile.am
-zfs-2.1.99/lib/libspl/include/sys/dktp/Makefile.in
-zfs-2.1.99/lib/libspl/include/sys/Makefile.am
-zfs-2.1.99/lib/libspl/include/sys/Makefile.in
-zfs-2.1.99/lib/libspl/include/util/Makefile.am
-zfs-2.1.99/lib/libspl/include/util/Makefile.in
-zfs-2.1.99/lib/libspl/Makefile.in
-zfs-2.1.99/lib/libtpool/Makefile.in
-zfs-2.1.99/lib/libunicode/Makefile.in
-zfs-2.1.99/lib/libuutil/Makefile.in
-zfs-2.1.99/lib/libzfsbootenv/Makefile.in
-zfs-2.1.99/lib/libzfs_core/Makefile.in
-zfs-2.1.99/lib/libzfs/Makefile.in
-zfs-2.1.99/lib/libzpool/Makefile.in
-zfs-2.1.99/lib/libzstd/Makefile.in
-zfs-2.1.99/lib/libzutil/Makefile.in
-zfs-2.1.99/lib/Makefile.in
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Closes #13316
2022-05-10 10:18:11 -07:00
7eba3891e9
zvol_wait: Ignore locked zvols
...
"When an encrypted zvol is locked the zfs-volume-wait service does not
start. The /sbin/zvol_wait should not wait for links when the volume
has property keystatus=unavailable."
-- https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1888405
Reviewed-by: Tony Hutter <hutter2@llnl.gov >
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com >
Thanks: James Dingwall <james-launchpad@dingwall.me.uk >
Signed-off-by: Richard Laager <rlaager@wiktel.com >
Closes #10662
2022-04-22 15:37:03 -07:00
8df0bde321
Add --enable=all to ShellCheck by default
...
Change enforced shell type from `dash` to `sh` and excluded
`SC2039` and `SC3043` by default. `local` keyword is accepted by all
POSIX shells from practical point of view. There is no need anymore
to enforce dash so `local` is accepted.
Reviewed-by: George Melikov <mail@gmelikov.ru >
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: szubersk <szuberskidamian@gmail.com >
Closes #13020
2022-02-07 11:59:09 -08:00
c1d3be19d7
Add ShellCheck's --enable=all inside cmd/
...
The only exception is `cmd/vdev_id/vdev_id` which might be a subject of
refactoring (see #12084 )
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Signed-off-by: szubersk <szuberskidamian@gmail.com >
Closes #12912
2022-01-06 16:07:54 -08:00
c3ef9f7528
Turn shellcheck into a normal make target. Fix new files it caught
...
This checks every file it checked (and a few more),
but explicitly instead of "if it works it works" best-effort
(which wasn't that good anyway)
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Closes #10512
Closes #12101
2021-06-01 11:38:49 -07:00
6fc3099248
Trim excess shellcheck annotations. Widen to all non-Korn scripts
...
Before, make shellcheck checked
scripts/{commitcheck,make_gitrev,man-dates,paxcheck,zfs-helpers,zfs,
zfs-tests,zimport,zloop}.sh
cmd/zed/zed.d/{{all-debug,all-syslog,data-notify,generic-notify,
resilver_finish-start-scrub,scrub_finish-notify,
statechange-led,statechange-notify,trim_finish-notify,
zed-functions}.sh,history_event-zfs-list-cacher.sh.in}
cmd/zpool/zpool.d/{dm-deps,iostat,lsblk,media,ses,smart,upath}
now it also checks
contrib/dracut/{02zfsexpandknowledge/module-setup,
90zfs/{export-zfs,parse-zfs,zfs-needshutdown,
zfs-load-key,zfs-lib,module-setup,
mount-zfs,zfs-generator}}.sh.in
cmd/zed/zed.d/{pool_import-led,vdev_attach-led,
resilver_finish-notify,vdev_clear-led}.sh
contrib/initramfs/{zfsunlock,hooks/zfs.in,scripts/local-top/zfs}
tests/zfs-tests/tests/perf/scripts/prefetch_io.sh
scripts/common.sh.in
contrib/bpftrace/zfs-trace.sh
autogen.sh
Reviewed-by: John Kennedy <john.kennedy@delphix.com >
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Closes #12042
2021-05-20 08:55:23 -07:00
d08dc34515
zvol_wait: properly handle zvol_volmode sysctl being 3/none
...
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com >
Reviewed-by: Ryan Moeller <ryan@iXsystems.com >
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Closes #11859
2021-04-11 11:58:36 -07:00
519aec83f5
zvol_wait: fix for zvols with spaces in name, optimise
...
list_zvols() would happily, for zvols with spaces in their names,
assign the second half to volmode, &c., so use a normal read
and set IFS to a tab instead of using 4 separate AWK processes(?)
Similarly, in filter_out_deleted_zvols(), run zfs(8) once and use the
output directly instead of spawning a zfs(8) process per zvol
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com >
Reviewed-by: Ryan Moeller <ryan@iXsystems.com >
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz >
Closes #11859
2021-04-11 11:56:53 -07:00
bf169e9f15
Fix various typos
...
Correct an assortment of typos throughout the code base.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Reviewed-by: Matthew Ahrens <mahrens@delphix.com >
Reviewed-by: Ryan Moeller <ryan@iXsystems.com >
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net >
Closes #11774
2021-04-02 18:52:15 -07:00
1c47c2c42c
zvol_wait should ignore redacted zvols
...
zvol_wait waits for zvol links to be created under /dev/zvol for each zvol.
Links are not created for redacted zvols so we should ignore those.
Reviewed-by: Paul Dagnelie <pcd@delphix.com >
Reviewed-by: Matt Ahrens <matt@delphix.com >
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com >
Closes #9545
2019-11-06 10:51:19 -08:00
a91e4790a6
zvol_wait script should ignore partially received zvols
...
Partially received zvols won't have links in /dev/zvol.
Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com >
Reviewed-by: Paul Dagnelie <pcd@delphix.com >
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Pavel Zakharov <pavel.zakharov@delphix.com >
Closes #9260
2019-09-03 11:29:52 -07:00
26b6047469
New service that waits on zvol links to be created
...
The zfs-volume-wait.service scans existing zvols and waits for their
links under /dev to be created. Any service that depends on zvol
links to be there should add a dependency on zfs-volumes.target.
By default, this target is not enabled.
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com >
Reviewed-by: Antonio Russo <antonio.e.russo@gmail.com >
Reviewed-by: Richard Laager <rlaager@wiktel.com >
Reviewed-by: loli10K <ezomori.nozomu@gmail.com >
Reviewed-by: John Gallagher <john.gallagher@delphix.com >
Reviewed-by: George Wilson <gwilson@delphix.com >
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Signed-off-by: Pavel Zakharov <pzakharov@delphix.com >
Closes #8975
2019-07-17 15:33:05 -07:00
наб