c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-09-15 13:50:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that gang_copies is always at least as large as copies

Browse Source 
As discussed in the comments of PR #17004, you can theoretically run
into a case where a gang child has more copies than the gang header,
which can lead to some odd accounting behavior (and even trip a
VERIFY). While the accounting code could be changed to handle this, it
fundamentally doesn't seem to make a lot of sense to allow this to
happen. If the data is supposed to have a certain level of reliability,
that isn't actually achieved unless the gang_copies property is set to
match it.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Paul Dagnelie <paul.dagnelie@klarasystems.com>
Closes #17484
This commit is contained in:
Paul Dagnelie 2025-06-25 09:05:36 -07:00 committed by Alexander Motin
parent 3ad3f439bb
commit fd5a27c9db
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
module/zfs/dmu.c
View File

@ -2496,7 +2496,8 @@ dmu_write_policy(objset_t *os, dnode_t *dn, int level, int wp, zio_prop_t *zp)
zp->zp_type = (wp & WP_SPILL) ? dn->dn_bonustype : type; zp->zp_type = (wp & WP_SPILL) ? dn->dn_bonustype : type;
zp->zp_level = level; zp->zp_level = level;
zp->zp_copies = MIN(copies, spa_max_replication(os->os_spa)); zp->zp_copies = MIN(copies, spa_max_replication(os->os_spa));
zp->zp_gang_copies = MIN(gang_copies, spa_max_replication(os->os_spa)); zp->zp_gang_copies = MIN(MAX(gang_copies, copies),
spa_max_replication(os->os_spa));
zp->zp_dedup = dedup; zp->zp_dedup = dedup;
zp->zp_dedup_verify = dedup && dedup_verify; zp->zp_dedup_verify = dedup && dedup_verify;
zp->zp_nopwrite = nopwrite; zp->zp_nopwrite = nopwrite;