mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2026-05-22 02:27:36 +03:00
Fix userspace memory leaks found by Clang Static Analzyer
Recently, I have been making a push to fix things that coverity found. However, I was curious what Clang's static analyzer reported, so I ran it and found things that coverity had missed. * contrib/pam_zfs_key/pam_zfs_key.c: If prop_mountpoint is passed more than once, we leak memory. * module/zfs/zcp_get.c: We leak memory on temporary properties in userspace. * tests/zfs-tests/cmd/draid.c: On error from vdev_draid_rand(), we leak memory if best_map had been allocated by a prior iteration. * tests/zfs-tests/cmd/mkfile.c: Memory used by the loop is not freed before program termination. Arguably, these are all minor issues, but if we ignore them, then they could obscure serious bugs, so we fix them. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13955
This commit is contained in:
@@ -472,6 +472,7 @@ get_zap_prop(lua_State *state, dsl_dataset_t *ds, zfs_prop_t zfs_prop)
|
||||
/* Fill in temporary value for prop, if applicable */
|
||||
(void) zfs_get_temporary_prop(ds, zfs_prop, &numval, setpoint);
|
||||
#else
|
||||
kmem_free(strval, ZAP_MAXVALUELEN);
|
||||
return (luaL_error(state,
|
||||
"temporary properties only supported in kernel mode",
|
||||
prop_name));
|
||||
|
||||
Reference in New Issue
Block a user