c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-05-22 02:27:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve tests and update man page for healing recv

Browse Source 
Fix the manpage. The "SYNOPSIS" section is incorrectly formatted for 
receive -c.  I also took this opportunity to reword some parts and 
fix a run-on sentence in the manpage.

Add large block testing for corrective recv. This adds a new test 
that makes sure blocks generated using zfs send -L/--large-block 
large-block send flag are able to be used for healing.

Since with unloaded key and errlog feature enabled corruption is not 
shown in zpool status #13675 is fixed the zfs_receive_corrective.ksh 
test no longer sets -o feature@head_errlog=disabled on pool creation 
so that it can also test for regressions related to head_errlog feature.

Note that the zfs_receive_compressed_corrective.ksh and
zfs_receive_large_block_corrective.ksh tests are still creating pools 
with -o feature@head_errlog=disabled.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alek Pinchuk <apinchuk@axcient.com>
Closes #14615
This commit is contained in:
Alek P
2023-03-15 10:34:10 -07:00
committed by GitHub
parent d74f123045
commit f55d6ee818
5 changed files with 204 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
man/man8/zfs-receive.8
+7 -8
View File
@@ -29,7 +29,7 @@
.\" Copyright 2018 Nexenta Systems, Inc.
.\" Copyright 2019 Joyent, Inc.
.\"
.Dd April 26, 2022
.Dd March 12, 2023
.Dt ZFS-RECEIVE 8
.Os
.
@@ -56,8 +56,7 @@
.Cm receive
.Fl A
.Ar filesystem Ns | Ns Ar volume
.
.Nm
.Nm zfs
.Cm receive
.Fl c
.Op Fl vn
@@ -406,15 +405,15 @@ deleting its saved partially received state.
.Op Fl vn
.Ar filesystem Ns | Ns Ar snapshot
.Xc
Attempt to correct data corruption in the specified dataset,
Attempt to repair data corruption in the specified dataset,
by using the provided stream as the source of healthy data.
This method of healing can only heal data blocks present in the stream.
Metadata can not be healed by corrective receive.
Running a scrub is recommended post-healing to ensure all corruption was
healed.
Running a scrub is recommended post-healing to ensure all data corruption was
repaired.
.Pp
It's important to consider why corruption has happened in the first place
since if you have slowly failing hardware periodically healing the data
It's important to consider why corruption has happened in the first place.
If you have slowly failing hardware - periodically repairing the data
is not going to save you from data loss later on when the hardware fails
completely.
.El