c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-27 11:29:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

De-inline spl_kthread_create().

Browse Source 
The function was defined as a static inline with variable arguments
which causes gcc to generate errors on some distros.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tim Chase <tim@chase2k.com>
Closes #346
This commit is contained in:
Tim Chase 2014-04-09 13:40:12 -05:00 committed by Brian Behlendorf
parent 17a527cb0f
commit ed650dee76
2 changed files with 30 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
include/sys/thread.h
View File

@ -59,33 +59,7 @@ extern kthread_t *__thread_create(caddr_t stk, size_t stksize,
void *args, size_t len, proc_t *pp, void *args, size_t len, proc_t *pp,
int state, pri_t pri); int state, pri_t pri);
extern void __thread_exit(void); extern void __thread_exit(void);
extern struct task_struct *spl_kthread_create(int (*func)(void *),
/* void *data, const char namefmt[], ...);
* spl_kthread_create - Wrapper providing pre-3.13 semantics for
* kthread_create() in which it is not killable and less likely
* to return -ENOMEM.
*/
static inline struct task_struct *
spl_kthread_create(int (*func)(void *), void *data, const char namefmt[], ...)
{
struct task_struct *tsk;
va_list args;
va_start(args, namefmt);
do {
tsk = kthread_create_on_node(func, data,
-1, namefmt, args);
if (IS_ERR(tsk)) {
if (signal_pending(current)) {
clear_thread_flag(TIF_SIGPENDING);
continue;
}
if (PTR_ERR(tsk) == -ENOMEM)
continue;
return (NULL);
} else
return (tsk);
} while (1);
}
#endif /* _SPL_THREAD_H */ #endif /* _SPL_THREAD_H */

28
module/spl/spl-thread.c
View File

@ -137,3 +137,31 @@ __thread_create(caddr_t stk, size_t stksize, thread_func_t func,
SRETURN((kthread_t *)tsk); SRETURN((kthread_t *)tsk);
} }
EXPORT_SYMBOL(__thread_create); EXPORT_SYMBOL(__thread_create);
/*
* spl_kthread_create - Wrapper providing pre-3.13 semantics for
* kthread_create() in which it is not killable and less likely
* to return -ENOMEM.
*/
struct task_struct *
spl_kthread_create(int (*func)(void *), void *data, const char namefmt[], ...)
{
struct task_struct *tsk;
va_list args;
va_start(args, namefmt);
do {
tsk = kthread_create(func, data, namefmt, args);
if (IS_ERR(tsk)) {
if (signal_pending(current)) {
clear_thread_flag(TIF_SIGPENDING);
continue;
}
if (PTR_ERR(tsk) == -ENOMEM)
continue;
return (NULL);
} else
return (tsk);
} while (1);
}
EXPORT_SYMBOL(spl_kthread_create);