c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-05-25 19:57:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix coverity defects: CID 147536, 147537, 147538

Browse Source 
coverity scan CID:147536, type: Argument cannot be negative
- may write or close fd which is negative
coverity scan CID:147537, type: Argument cannot be negative
- may call dup2 with a negative fd
coverity scan CID:147538, type: Argument cannot be negative
- may read or fchown with a negative fd

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: GeLiXin <ge.lixin@zte.com.cn>
Closes #5185
This commit is contained in:
GeLiXin
2016-10-01 06:40:07 +08:00
committed by Brian Behlendorf
parent 292d573e70
commit ed3ea30fb9
3 changed files with 25 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/zfs-tests/cmd/rm_lnkcnt_zero_file/rm_lnkcnt_zero_file.c
Regular → Executable
+8 -3
View File
@@ -103,10 +103,15 @@ writer(void *a)
int ret;
while (TRUE) {
(void) close (*fd);
if (*fd != -1)
(void) close (*fd);
*fd = open(filebase, O_APPEND | O_RDWR | O_CREAT, 0644);
if (*fd < 0)
perror("refreshing file");
if (*fd == -1) {
perror("fail to open test file, refreshing it");
continue;
}
ret = write(*fd, "test\n", 5);
if (ret != 5)
perror("writing file");