mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2026-05-24 03:08:51 +03:00
Use percpu_counter for obj_alloc counter of Linux-backed caches
A previous commit enabled the tracking of object allocations in Linux-backed caches from the SPL layer for debuggability. The commit is: 9a170fc6fe54f1e852b6c39630fe5ef2bbd97c16 Unfortunately, it also introduced minor performance regressions that were highlighted by the ZFS perf test-suite. Within Delphix we found that the regression would be from -1%, all the way up to -8% for some workloads. This commit brings performance back up to par by creating a separate counter for those caches and making it a percpu in order to avoid lock-contention. The initial performance testing was done by myself, and the final round was conducted by @tonynguien who was also the one that discovered the regression and highlighted the culprit. Reviewed-by: Matt Ahrens <matt@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Serapheim Dimitropoulos <serapheim@delphix.com> Closes #10397
This commit is contained in:
committed by
GitHub
parent
7b232e9354
commit
ec1fea4516
@@ -446,16 +446,18 @@ slab_seq_show(struct seq_file *f, void *p)
|
||||
* the underlying Linux cache please refer to /proc/slabinfo.
|
||||
*/
|
||||
spin_lock(&skc->skc_lock);
|
||||
uint64_t objs_allocated =
|
||||
percpu_counter_sum(&skc->skc_linux_alloc);
|
||||
seq_printf(f, "%-36s ", skc->skc_name);
|
||||
seq_printf(f, "0x%05lx %9s %9lu %8s %8u "
|
||||
"%5s %5s %5s %5s %5lu %5s %5s %5s %5s\n",
|
||||
(long unsigned)skc->skc_flags,
|
||||
"-",
|
||||
(long unsigned)(skc->skc_obj_size * skc->skc_obj_alloc),
|
||||
(long unsigned)(skc->skc_obj_size * objs_allocated),
|
||||
"-",
|
||||
(unsigned)skc->skc_obj_size,
|
||||
"-", "-", "-", "-",
|
||||
(long unsigned)skc->skc_obj_alloc,
|
||||
(long unsigned)objs_allocated,
|
||||
"-", "-", "-", "-");
|
||||
spin_unlock(&skc->skc_lock);
|
||||
return (0);
|
||||
|
||||
Reference in New Issue
Block a user