c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-25 02:49:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix stack ddt_class_contains()

Browse Source 
Stack usage for ddt_class_contains() reduced from 524 bytes to 68
bytes.  This large stack allocation significantly contributed to
the likelyhood of a stack overflow when scrubbing/resilvering
dedup pools.
This commit is contained in:
Brian Behlendorf 2011-05-25 13:56:40 -07:00
parent 5b8c7bbcea
commit e95b3bdcbb
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
module/zfs/ddt.c
View File

@ -891,7 +891,7 @@ boolean_t
ddt_class_contains(spa_t *spa, enum ddt_class max_class, const blkptr_t *bp) ddt_class_contains(spa_t *spa, enum ddt_class max_class, const blkptr_t *bp)
{ {
ddt_t *ddt; ddt_t *ddt;
ddt_entry_t dde; ddt_entry_t *dde;
enum ddt_type type; enum ddt_type type;
enum ddt_class class; enum ddt_class class;
@ -902,14 +902,20 @@ ddt_class_contains(spa_t *spa, enum ddt_class max_class, const blkptr_t *bp)
return (B_TRUE); return (B_TRUE);
ddt = spa->spa_ddt[BP_GET_CHECKSUM(bp)]; ddt = spa->spa_ddt[BP_GET_CHECKSUM(bp)];
dde = kmem_alloc(sizeof(ddt_entry_t), KM_SLEEP);
ddt_key_fill(&dde.dde_key, bp); ddt_key_fill(&(dde->dde_key), bp);
for (type = 0; type < DDT_TYPES; type++) for (type = 0; type < DDT_TYPES; type++) {
for (class = 0; class <= max_class; class++) for (class = 0; class <= max_class; class++) {
if (ddt_object_lookup(ddt, type, class, &dde) == 0) if (ddt_object_lookup(ddt, type, class, dde) == 0) {
kmem_free(dde, sizeof(ddt_entry_t));
return (B_TRUE); return (B_TRUE);
}
}
}
kmem_free(dde, sizeof(ddt_entry_t));
return (B_FALSE); return (B_FALSE);
} }