From e6eb03a9915399edd96be636190e2b1a2d748f1c Mon Sep 17 00:00:00 2001
From: Rob Norris <rob.norris@klarasystems.com>
Date: Fri, 25 Jul 2025 13:17:18 +1000
Subject: [PATCH] zvol_check_volblocksize: fix spa ref leak

Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Reviewed-by: Fedor Uporov <fuporov.vstack@gmail.com>
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
Sponsored-by: Klara, Inc.
Sponsored-by: Railway Corporation
Closes #17596
---
 module/zfs/zvol.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/module/zfs/zvol.c b/module/zfs/zvol.c
index ea61f33b6..af855fe41 100644
--- a/module/zfs/zvol.c
+++ b/module/zfs/zvol.c
@@ -450,8 +450,10 @@ zvol_check_volblocksize(const char *name, uint64_t volblocksize)
 		 * We don't allow setting the property above 1MB,
 		 * unless the tunable has been changed.
 		 */
-		if (volblocksize > zfs_max_recordsize)
+		if (volblocksize > zfs_max_recordsize) {
+			spa_close(spa, FTAG);
 			return (SET_ERROR(EDOM));
+		}
 
 		spa_close(spa, FTAG);
 	}