From e3e7cf6026f0761c155ae7920b03fb76c7ad5df8 Mon Sep 17 00:00:00 2001 From: DHE Date: Sun, 27 Mar 2016 15:58:27 -0400 Subject: [PATCH] gcc build error: -Wbool-compare in metaslab.c When debugging is enabled on a very recent version of gcc (tested with 5.3.0), DVA_SET_GANG(dva, !!(flags)) fails because an assertion causes a comparison between what is technically a boolean and an integer. Signed-off-by: DHE Signed-off-by: Brian Behlendorf Closes #4465 --- module/zfs/metaslab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/module/zfs/metaslab.c b/module/zfs/metaslab.c index 19323cdb8..c2c1d2dfc 100644 --- a/module/zfs/metaslab.c +++ b/module/zfs/metaslab.c @@ -2390,7 +2390,8 @@ top: DVA_SET_VDEV(&dva[d], vd->vdev_id); DVA_SET_OFFSET(&dva[d], offset); - DVA_SET_GANG(&dva[d], !!(flags & METASLAB_GANG_HEADER)); + DVA_SET_GANG(&dva[d], + ((flags & METASLAB_GANG_HEADER) ? 1 : 0)); DVA_SET_ASIZE(&dva[d], asize); if (flags & METASLAB_FASTWRITE) {