c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-26 11:19:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Move assert in dump_dir() in zdb

Browse Source 
This one line patch moves an assert in the function dump_dir()
below an error check that ensures it ran correctly. This ensures
zdb dumps the error that actually caused the problem, as opposed
to one of its symptoms.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #8171
This commit is contained in:
Tom Caputi 2018-12-05 12:30:28 -05:00 committed by Brian Behlendorf
parent 78e2139467
commit e3c85c0938
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/zdb/zdb.c
View File

@ -2522,15 +2522,15 @@ dump_dir(objset_t *os)
(void) printf("\tPercent empty: %10lf\n", (void) printf("\tPercent empty: %10lf\n",
(double)(max_slot_used - total_slots_used)*100 / (double)(max_slot_used - total_slots_used)*100 /
(double)max_slot_used); (double)max_slot_used);
ASSERT3U(object_count, ==, usedobjs);
(void) printf("\n"); (void) printf("\n");
if (error != ESRCH) { if (error != ESRCH) {
(void) fprintf(stderr, "dmu_object_next() = %d\n", error); (void) fprintf(stderr, "dmu_object_next() = %d\n", error);
abort(); abort();
} }
ASSERT3U(object_count, ==, usedobjs);
if (leaked_objects != 0) { if (leaked_objects != 0) {
(void) printf("%d potentially leaked objects detected\n", (void) printf("%d potentially leaked objects detected\n",
leaked_objects); leaked_objects);