c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-04-30 14:08:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

zed: agents: zfs_diagnosis: fix unused, remove argsused

Browse Source 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12835
This commit is contained in:
наб 2021-12-11 01:18:01 +01:00 committed by Brian Behlendorf
parent 16529f305a
commit e265a082eb
1 changed files with 16 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
cmd/zed/agents/zfs_diagnosis.c
View File

@ -119,7 +119,7 @@ uu_list_t *zfs_cases;
* Write out the persistent representation of an active case. * Write out the persistent representation of an active case.
*/ */
static void static void
zfs_case_serialize(fmd_hdl_t *hdl, zfs_case_t *zcp) zfs_case_serialize(zfs_case_t *zcp)
{ {
zcp->zc_data.zc_version = CASE_DATA_VERSION_SERD; zcp->zc_data.zc_version = CASE_DATA_VERSION_SERD;
} }
@ -209,10 +209,10 @@ zfs_mark_vdev(uint64_t pool_guid, nvlist_t *vd, er_timeval_t *loaded)
} }
} }
/*ARGSUSED*/
static int static int
zfs_mark_pool(zpool_handle_t *zhp, void *unused) zfs_mark_pool(zpool_handle_t *zhp, void *unused)
{ {
(void) unused;
zfs_case_t *zcp; zfs_case_t *zcp;
uint64_t pool_guid; uint64_t pool_guid;
uint64_t *tod; uint64_t *tod;
@ -373,8 +373,7 @@ zfs_serd_name(char *buf, uint64_t pool_guid, uint64_t vdev_guid,
* case. * case.
*/ */
static void static void
zfs_case_solve(fmd_hdl_t *hdl, zfs_case_t *zcp, const char *faultname, zfs_case_solve(fmd_hdl_t *hdl, zfs_case_t *zcp, const char *faultname)
boolean_t checkunusable)
{ {
nvlist_t *detector, *fault; nvlist_t *detector, *fault;
boolean_t serialize; boolean_t serialize;
@ -412,7 +411,7 @@ zfs_case_solve(fmd_hdl_t *hdl, zfs_case_t *zcp, const char *faultname,
serialize = B_TRUE; serialize = B_TRUE;
} }
if (serialize) if (serialize)
zfs_case_serialize(hdl, zcp); zfs_case_serialize(zcp);
nvlist_free(detector); nvlist_free(detector);
} }
@ -424,10 +423,10 @@ timeval_earlier(er_timeval_t *a, er_timeval_t *b)
(a->ertv_sec == b->ertv_sec && a->ertv_nsec < b->ertv_nsec)); (a->ertv_sec == b->ertv_sec && a->ertv_nsec < b->ertv_nsec));
} }
/*ARGSUSED*/
static void static void
zfs_ereport_when(fmd_hdl_t *hdl, nvlist_t *nvl, er_timeval_t *when) zfs_ereport_when(fmd_hdl_t *hdl, nvlist_t *nvl, er_timeval_t *when)
{ {
(void) hdl;
int64_t *tod; int64_t *tod;
uint_t nelem; uint_t nelem;
@ -443,7 +442,6 @@ zfs_ereport_when(fmd_hdl_t *hdl, nvlist_t *nvl, er_timeval_t *when)
/* /*
* Main fmd entry point. * Main fmd entry point.
*/ */
/*ARGSUSED*/
static void static void
zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class) zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
{ {
@ -686,7 +684,7 @@ zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
if (zcp->zc_data.zc_has_remove_timer) { if (zcp->zc_data.zc_has_remove_timer) {
fmd_timer_remove(hdl, zcp->zc_remove_timer); fmd_timer_remove(hdl, zcp->zc_remove_timer);
zcp->zc_data.zc_has_remove_timer = 0; zcp->zc_data.zc_has_remove_timer = 0;
zfs_case_serialize(hdl, zcp); zfs_case_serialize(zcp);
} }
if (zcp->zc_data.zc_serd_io[0] != '\0') if (zcp->zc_data.zc_serd_io[0] != '\0')
fmd_serd_reset(hdl, zcp->zc_data.zc_serd_io); fmd_serd_reset(hdl, zcp->zc_data.zc_serd_io);
@ -751,18 +749,18 @@ zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
fmd_case_close(hdl, dcp->zc_case); fmd_case_close(hdl, dcp->zc_case);
} }
zfs_case_solve(hdl, zcp, "fault.fs.zfs.pool", B_TRUE); zfs_case_solve(hdl, zcp, "fault.fs.zfs.pool");
} else if (fmd_nvl_class_match(hdl, nvl, } else if (fmd_nvl_class_match(hdl, nvl,
ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_LOG_REPLAY))) { ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_LOG_REPLAY))) {
/* /*
* Pool level fault for reading the intent logs. * Pool level fault for reading the intent logs.
*/ */
zfs_case_solve(hdl, zcp, "fault.fs.zfs.log_replay", B_TRUE); zfs_case_solve(hdl, zcp, "fault.fs.zfs.log_replay");
} else if (fmd_nvl_class_match(hdl, nvl, "ereport.fs.zfs.vdev.*")) { } else if (fmd_nvl_class_match(hdl, nvl, "ereport.fs.zfs.vdev.*")) {
/* /*
* Device fault. * Device fault.
*/ */
zfs_case_solve(hdl, zcp, "fault.fs.zfs.device", B_TRUE); zfs_case_solve(hdl, zcp, "fault.fs.zfs.device");
} else if (fmd_nvl_class_match(hdl, nvl, } else if (fmd_nvl_class_match(hdl, nvl,
ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_IO)) || ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_IO)) ||
fmd_nvl_class_match(hdl, nvl, fmd_nvl_class_match(hdl, nvl,
@ -789,7 +787,7 @@ zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
fmd_serd_create(hdl, zcp->zc_data.zc_serd_io, fmd_serd_create(hdl, zcp->zc_data.zc_serd_io,
fmd_prop_get_int32(hdl, "io_N"), fmd_prop_get_int32(hdl, "io_N"),
fmd_prop_get_int64(hdl, "io_T")); fmd_prop_get_int64(hdl, "io_T"));
zfs_case_serialize(hdl, zcp); zfs_case_serialize(zcp);
} }
if (fmd_serd_record(hdl, zcp->zc_data.zc_serd_io, ep)) if (fmd_serd_record(hdl, zcp->zc_data.zc_serd_io, ep))
checkremove = B_TRUE; checkremove = B_TRUE;
@ -802,12 +800,12 @@ zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
zcp->zc_data.zc_serd_checksum, zcp->zc_data.zc_serd_checksum,
fmd_prop_get_int32(hdl, "checksum_N"), fmd_prop_get_int32(hdl, "checksum_N"),
fmd_prop_get_int64(hdl, "checksum_T")); fmd_prop_get_int64(hdl, "checksum_T"));
zfs_case_serialize(hdl, zcp); zfs_case_serialize(zcp);
} }
if (fmd_serd_record(hdl, if (fmd_serd_record(hdl,
zcp->zc_data.zc_serd_checksum, ep)) { zcp->zc_data.zc_serd_checksum, ep)) {
zfs_case_solve(hdl, zcp, zfs_case_solve(hdl, zcp,
"fault.fs.zfs.vdev.checksum", B_FALSE); "fault.fs.zfs.vdev.checksum");
} }
} else if (fmd_nvl_class_match(hdl, nvl, } else if (fmd_nvl_class_match(hdl, nvl,
ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_IO_FAILURE)) && ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_IO_FAILURE)) &&
@ -817,12 +815,11 @@ zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
if (strncmp(failmode, FM_EREPORT_FAILMODE_CONTINUE, if (strncmp(failmode, FM_EREPORT_FAILMODE_CONTINUE,
strlen(FM_EREPORT_FAILMODE_CONTINUE)) == 0) { strlen(FM_EREPORT_FAILMODE_CONTINUE)) == 0) {
zfs_case_solve(hdl, zcp, zfs_case_solve(hdl, zcp,
"fault.fs.zfs.io_failure_continue", "fault.fs.zfs.io_failure_continue");
B_FALSE);
} else if (strncmp(failmode, FM_EREPORT_FAILMODE_WAIT, } else if (strncmp(failmode, FM_EREPORT_FAILMODE_WAIT,
strlen(FM_EREPORT_FAILMODE_WAIT)) == 0) { strlen(FM_EREPORT_FAILMODE_WAIT)) == 0) {
zfs_case_solve(hdl, zcp, zfs_case_solve(hdl, zcp,
"fault.fs.zfs.io_failure_wait", B_FALSE); "fault.fs.zfs.io_failure_wait");
} }
} else if (fmd_nvl_class_match(hdl, nvl, } else if (fmd_nvl_class_match(hdl, nvl,
ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_PROBE_FAILURE))) { ZFS_MAKE_EREPORT(FM_EREPORT_ZFS_PROBE_FAILURE))) {
@ -844,7 +841,7 @@ zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
zfs_remove_timeout); zfs_remove_timeout);
if (!zcp->zc_data.zc_has_remove_timer) { if (!zcp->zc_data.zc_has_remove_timer) {
zcp->zc_data.zc_has_remove_timer = 1; zcp->zc_data.zc_has_remove_timer = 1;
zfs_case_serialize(hdl, zcp); zfs_case_serialize(zcp);
} }
} }
} }
@ -854,14 +851,13 @@ zfs_fm_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl, const char *class)
* The timeout is fired when we diagnosed an I/O error, and it was not due to * The timeout is fired when we diagnosed an I/O error, and it was not due to
* device removal (which would cause the timeout to be cancelled). * device removal (which would cause the timeout to be cancelled).
*/ */
/* ARGSUSED */
static void static void
zfs_fm_timeout(fmd_hdl_t *hdl, id_t id, void *data) zfs_fm_timeout(fmd_hdl_t *hdl, id_t id, void *data)
{ {
zfs_case_t *zcp = data; zfs_case_t *zcp = data;
if (id == zcp->zc_remove_timer) if (id == zcp->zc_remove_timer)
zfs_case_solve(hdl, zcp, "fault.fs.zfs.vdev.io", B_FALSE); zfs_case_solve(hdl, zcp, "fault.fs.zfs.vdev.io");
} }
/* /*