mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2026-05-24 11:18:52 +03:00
Use _Noreturn (C11; GNU89) properly
A function that returns with no value is a different thing from a
function that doesn't return at all. Those are two orthogonal
concepts, commonly confused.
pthread_create(3) expects a pointer to a start routine that has a
very precise prototype:
void *(*start_routine)(void *);
However, other thread functions, such as kernel ones, expect:
void (*start_routine)(void *);
Providing a different one is incorrect, and has only been working
because the ABIs happen to produce a compatible function.
We should use '_Noreturn void', since it's the natural type, and
then provide a '_Noreturn void *' wrapper for pthread functions.
For consistency, replace most cases of __NORETURN or
__attribute__((noreturn)) by _Noreturn. _Noreturn is understood
by -std=gnu89, so it should be safe to use everywhere.
Ref: https://github.com/openzfs/zfs/pull/13110#discussion_r808450136
Ref: https://software.codidact.com/posts/285972
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Closes #13120
This commit is contained in:
committed by
GitHub
parent
06b8050678
commit
db7f1a91de
@@ -24,11 +24,6 @@ AM_CFLAGS += $(ZLIB_CFLAGS)
|
||||
|
||||
AM_CFLAGS += -DLIB_ZPOOL_BUILD
|
||||
|
||||
# For the void (*)(void *) -> void *(*)(void *) cast in zk_thread_create()
|
||||
# See https://github.com/openzfs/zfs/pull/13110#discussion_r808450136
|
||||
kernel.$(OBJEXT): CFLAGS += $(NO_CAST_FUNCTION_TYPE)
|
||||
kernel.l$(OBJEXT): CFLAGS += $(NO_CAST_FUNCTION_TYPE)
|
||||
|
||||
lib_LTLIBRARIES = libzpool.la
|
||||
|
||||
USER_C = \
|
||||
|
||||
Reference in New Issue
Block a user