From d296b094566a981984e29b5b87d8e5aa9dbda703 Mon Sep 17 00:00:00 2001 From: Tony Hutter Date: Fri, 6 Apr 2018 16:32:58 -0700 Subject: [PATCH] Exclude python scripts from RPM shebang check The newest Fedora packaging rules print warnings for scripts using the /usr/bin/python shebang: *** WARNING: mangling shebang in /usr/bin/arc_summary.py from #!/usr/bin/python to #!/usr/bin/python2. This will become an ERROR, fix it manually! Fedora wants all cross compatible scripts to pick python3. Since we don't want our users to have to pick a specific version of python, we exclude our scripts from the RPM build check. Reviewed-by: Brian Behlendorf Reviewed-by: Giuseppe Di Natale Signed-off-by: Tony Hutter Closes #7360 Closes #7399 --- rpm/generic/zfs.spec.in | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/rpm/generic/zfs.spec.in b/rpm/generic/zfs.spec.in index 0a5d1c543..3a46c127e 100644 --- a/rpm/generic/zfs.spec.in +++ b/rpm/generic/zfs.spec.in @@ -36,6 +36,16 @@ %bcond_with debug %bcond_with systemd +# Python permits the !/usr/bin/python shebang for scripts that are cross +# compatible between python2 and python3, but Fedora 28 does not. Fedora +# wants us to choose python3 for cross-compatible scripts. Since we want +# to support python2 and python3 users, exclude our scripts from Fedora 28's +# RPM build check, so that we don't get a bunch of build warnings. +# +# Details: https://github.com/zfsonlinux/zfs/issues/7360 +# +%global __brp_mangle_shebangs_exclude_from arc_summary.py|arcstat.py|dbufstat.py|test-runner.py + # Generic enable switch for systemd %if %{with systemd} %define _systemd 1