c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-25 18:59:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add test with two kinds of file creation orders

Browse Source 
Data loss was identified in #7401 when many small files were copied.
This adds a reproducer for this bug and other similar ones: randomly
generate N files. Then, listing M of them by `ls -U` order, produce
those same files in a directory of the same name.

This triggers the bug consistently, provided N and M are large enough.
Here, N=2^16 and M=2^13.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
Closes #7411
This commit is contained in:
Antonio Russo 2018-04-30 13:45:47 -04:00 committed by Brian Behlendorf
parent 964c2d69a9
commit c83ccb3e72
4 changed files with 55 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/runfiles/linux.run
View File

@ -600,7 +600,7 @@ tests = ['umount_001', 'umountall_001']
tags = ['functional', 'mount']
[tests/functional/mv_files]
tests = ['mv_files_001_pos', 'mv_files_002_pos']
tests = ['mv_files_001_pos', 'mv_files_002_pos', 'random_creation']
tags = ['functional', 'mv_files']
[tests/functional/nestedfs]

3
tests/zfs-tests/tests/functional/mv_files/Makefile.am
View File

@ -3,7 +3,8 @@ dist_pkgdata_SCRIPTS = \
setup.ksh \
cleanup.ksh \
mv_files_001_pos.ksh \
mv_files_002_pos.ksh
mv_files_002_pos.ksh \
random_creation.ksh
dist_pkgdata_DATA = \
mv_files.cfg \

4
tests/zfs-tests/tests/functional/mv_files/mv_files.cfg
View File

@ -44,3 +44,7 @@ export NEWDIR_ACROSS_FS=$TESTDIR_TGT/newdir
export MVNUMFILES=2000 # <number of files to start>
export MVNUMINCR=1000 # <number of files to be increased to>
export GANGPIDS=50 # <number of limit for parallel background running process>
# controls the "random_creation" test
export RC_PASS1=65536 # <number of files to create in the first directory>
export RC_PASS2=8192 # <process this many files into the second directory

48
tests/zfs-tests/tests/functional/mv_files/random_creation.ksh Executable file
View File

@ -0,0 +1,48 @@
#!/bin/ksh -p
source "${STF_SUITE}/include/libtest.shlib"
source "${STF_SUITE}/tests/functional/mv_files/mv_files.cfg"
# This will test the #7401 regression.
log_assert "Check that creating many files quickly is safe"
DIR="${TESTDIR}/RANDOM_SMALL"
log_must mkdir "${DIR}"
count=0
for i in $(shuf -i 1-"${RC_PASS1}") ; do
if ! touch "${DIR}/${i}" ; then
log_fail "error creating ${i} after ${count} files"
fi
count=$((count+1))
done
visible="$(find "${DIR}" -type f|wc -l)"
log_must [ "${visible}" -eq "${RC_PASS1}" ]
log_assert "Check that creating them in another order is safe"
DIR1="${TESTDIR}/RANDOM2"
log_must mv "${DIR}" "${DIR1}"
log_must mkdir "${DIR}"
count=0
for i in $(cd "${DIR1}" ; ls -U . ) ; do
if ! touch "${DIR}/${i}" ; then
log_fail "error creating ${i} after ${count} files"
fi
count=$((count+1))
[ "${count}" -eq "${RC_PASS2}" ] && break
done
visible="$(find "${DIR}" -type f|wc -l)"
if [ "${visible}" -eq "${RC_PASS2}" ] ; then
log_pass "Created all ${RC_PASS2} files"
else
log_fail "Number of created files ${visible} is not ${RC_PASS2}"
fi