mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2026-05-24 03:08:51 +03:00
Turn shellcheck into a normal make target. Fix new files it caught
This checks every file it checked (and a few more), but explicitly instead of "if it works it works" best-effort (which wasn't that good anyway) Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes #10512 Closes #12101
This commit is contained in:
+7
-5
@@ -6,19 +6,21 @@ pkgcfg=/etc/sysconfig/zfs
|
||||
|
||||
while getopts "n:v:c:f:" opt; do
|
||||
case $opt in
|
||||
n) pkgname=$OPTARG ;;
|
||||
v) pkgver=$OPTARG ;;
|
||||
c) pkgcfg=$OPTARG ;;
|
||||
n) pkgname=$OPTARG ;;
|
||||
v) pkgver=$OPTARG ;;
|
||||
c) pkgcfg=$OPTARG ;;
|
||||
f) filename=$OPTARG ;;
|
||||
*) err=1 ;;
|
||||
esac
|
||||
done
|
||||
|
||||
if [ -z "${pkgname}" ] || [ -z "${pkgver}" ] || [ -z "${filename}" ]; then
|
||||
if [ -z "${pkgname}" ] || [ -z "${pkgver}" ] || [ -z "${filename}" ] ||
|
||||
[ -n "${err}" ]; then
|
||||
echo "Usage: $PROG -n <pkgname> -v <pkgver> -c <pkgcfg> -f <filename>"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
cat >${filename} <<EOF
|
||||
exec cat >"${filename}" <<EOF
|
||||
PACKAGE_NAME="${pkgname}"
|
||||
PACKAGE_VERSION="${pkgver}"
|
||||
PACKAGE_CONFIG="${pkgcfg}"
|
||||
|
||||
Reference in New Issue
Block a user