mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-25 18:59:33 +03:00
Linux: Silence static analyzer warning in crypto_create_ctx_template()
A CodeChecker report from Clang's CTU analysis indicated that we were assigning uninitialized values in crypto_create_ctx_template() when we call it from zio_crypt_key_init(). This occurs because the ->cm_param and ->cm_param_len fields are uninitialized. Thankfully, the uninitialized values are only used in the skein via KCF_PROV_CREATE_CTX_TEMPLATE() -> skein_create_ctx_template() -> skein_mac_ctx_build() -> skein_get_digest_bitlen(), but that should not be called from here. We fix this to avoid a possible trap should this code change in the future. The FreeBSD version of zio_crypt_key_init() is unaffected. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #14575
This commit is contained in:
parent
51f55742f6
commit
c2550a136e
@ -223,7 +223,7 @@ int
|
||||
zio_crypt_key_init(uint64_t crypt, zio_crypt_key_t *key)
|
||||
{
|
||||
int ret;
|
||||
crypto_mechanism_t mech;
|
||||
crypto_mechanism_t mech = {0};
|
||||
uint_t keydata_len;
|
||||
|
||||
ASSERT(key != NULL);
|
||||
|
Loading…
Reference in New Issue
Block a user