From c1848f7261a949d972df6f2860feffd0fa8d9752 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20F=C3=BCl=C3=B6p?= Date: Fri, 30 May 2025 03:04:20 +0200 Subject: [PATCH] Linux build: always use objtool MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We silence `objtool` warnings on some object files using `OBJECT_FILES_NON_STANDARD_some_file.o`. Nowadays `objtool` is needed for CPU vulnerability mitigations and a lot more functionality so its use is desirable. Just remove the `OBJECT_FILES_NON_STANDARD` definitions. A follow-up commit is needed to make the offending files standard and address the compile time warnings. Reviewed-by: Tino Reichardt Reviewed-by: Tony Hutter Reviewed-by: Brian Behlendorf Signed-off-by: Attila Fülöp Closes #17401 Closes #17364 --- module/Kbuild.in | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/module/Kbuild.in b/module/Kbuild.in index 4afd06493..e7790c6b9 100644 --- a/module/Kbuild.in +++ b/module/Kbuild.in @@ -180,14 +180,6 @@ $(addprefix $(obj)/icp/,$(ICP_OBJS) $(ICP_OBJS_X86) $(ICP_OBJS_X86_64) \ $(addprefix $(obj)/icp/,$(ICP_OBJS) $(ICP_OBJS_X86) $(ICP_OBJS_X86_64) \ $(ICP_OBJS_ARM64) $(ICP_OBJS_PPC_PPC64)) : ccflags-y += -I$(icp_include) -I$(zfs_include)/os/linux/spl -I$(zfs_include) -# Suppress objtool "return with modified stack frame" warnings. -OBJECT_FILES_NON_STANDARD_aesni-gcm-x86_64.o := y - -# Suppress objtool "unsupported stack pointer realignment" warnings. -# See #6950 for the reasoning. -OBJECT_FILES_NON_STANDARD_sha256-x86_64.o := y -OBJECT_FILES_NON_STANDARD_sha512-x86_64.o := y - LUA_OBJS := \ lapi.o \ lauxlib.o \ @@ -498,11 +490,6 @@ UBSAN_SANITIZE_sa.o := n UBSAN_SANITIZE_zfs/zap_micro.o := n UBSAN_SANITIZE_zfs/sa.o := n -# Suppress incorrect warnings from versions of objtool which are not -# aware of x86 EVEX prefix instructions used for AVX512. -OBJECT_FILES_NON_STANDARD_vdev_raidz_math_avx512bw.o := y -OBJECT_FILES_NON_STANDARD_vdev_raidz_math_avx512f.o := y - ifeq ($(CONFIG_ALTIVEC),y) $(obj)/zfs/vdev_raidz_math_powerpc_altivec.o : c_flags += -maltivec endif