c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-11-17 18:11:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

Return -1 for generic kmem cache shrinker

Browse Source 
It has been observed that it's possible to get in a state where
shrink_slabs() will spin repeated invoking the generic kmem cache
shrinker.  It fails to detect it's not making forward progress
reclaiming from the cache and doesn't give up.  To ensure this
never occurs we unconditionally return -1 after reclaiming what
we can.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <ryao@gentoo.org>
Closes zfsonlinux/zfs#1276
Closes zfsonlinux/zfs#1598
Closes zfsonlinux/zfs#1432
This commit is contained in:
Brian Behlendorf 2013-07-23 15:52:11 -07:00
parent c47efbc7fd
commit b9b3715346
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
module/spl/spl-kmem.c
View File

@ -2122,7 +2122,15 @@ __spl_kmem_cache_generic_shrinker(struct shrinker *shrink,
} }
up_read(&spl_kmem_cache_sem); up_read(&spl_kmem_cache_sem);
return (unused * sysctl_vfs_cache_pressure) / 100; /*
* After performing reclaim always return -1 to indicate we cannot
* perform additional reclaim. This prevents shrink_slabs() from
* repeatedly invoking this generic shrinker and potentially spinning.
*/
if (sc->nr_to_scan)
return -1;
return unused;
} }
SPL_SHRINKER_CALLBACK_WRAPPER(spl_kmem_cache_generic_shrinker); SPL_SHRINKER_CALLBACK_WRAPPER(spl_kmem_cache_generic_shrinker);