c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-05-30 18:56:23 +03:00
Code Issues Packages Projects Releases Wiki Activity

ZTS: Refactor is_shared, fix impl on FreeBSD

Browse Source 
FreeBSD doesn't have a `share` command.  It does have showmount.

Split the separate platform impls out of is_shared_impl.
Dispatch to the correct platform impl function from is_shared.
Eliminate the use of is_shared_impl from tests.  is_shared works.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #10037
This commit is contained in:
Ryan Moeller
2020-02-21 18:59:20 -05:00
committed by GitHub
parent f5f438194d
commit b7dbbf6aa7
3 changed files with 29 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/zfs-tests/tests/functional/cli_root/zfs_unshare/zfs_unshare_007_pos.ksh
+2 -6
View File
@@ -57,16 +57,12 @@ log_must zfs create \
#
# 2. Verify the datasets is shared.
#
# The "non-impl" variant of "is_shared" requires the dataset to exist.
# Thus, we can only use the "impl" variant in step 4, below. To be
# consistent with step 4, we also use the "impl" variant here.
#
log_must eval "is_shared_impl $TESTDIR/1"
log_must is_shared $TESTDIR/1
# 3. Invoke 'zfs destroy' on the dataset.
log_must zfs destroy -f $TESTPOOL/$TESTFS/shared1
# 4. Verify the dataset is not shared.
log_mustnot eval "is_shared_impl $TESTDIR/1"
log_mustnot is_shared $TESTDIR/1
log_pass "'zfs destroy' will unshare the dataset."