From b264d9b3e5b2b5b8eaeef7b34eb7b1b6caf4e4fb Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Fri, 29 Jul 2016 12:40:30 +0100 Subject: [PATCH] libzfs: Fix missing va_end call on ENOSPC and EDQUOT cases The switch statement in function zfs_standard_error_fmt for the ENOSPC and EDQUOT cases returns immediately and unlike all other cases in the switch this does not perform the va_end call. Perform a break which ends up calling va_end rather than returning immediately. Found by static analysis with CoverityScan 0.8.5 Signed-off-by: Colin Ian King Signed-off-by: Brian Behlendorf Closes #4900 --- lib/libzfs/libzfs_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libzfs/libzfs_util.c b/lib/libzfs/libzfs_util.c index 926ed4ed8..8fe59a0c0 100644 --- a/lib/libzfs/libzfs_util.c +++ b/lib/libzfs/libzfs_util.c @@ -390,7 +390,7 @@ zfs_standard_error_fmt(libzfs_handle_t *hdl, int error, const char *fmt, ...) case ENOSPC: case EDQUOT: zfs_verror(hdl, EZFS_NOSPC, fmt, ap); - return (-1); + break; case EEXIST: zfs_error_aux(hdl, dgettext(TEXT_DOMAIN,