c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-25 18:59:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Bump commit subject length to 72 characters

Browse Source 
There's not really a reason to keep the subject length so short,
since the reason to make it this short was for making nice renders
of a summary list of the git log. With 72 characters, this still
works out fine, so let's just raise it to that so that it's easier
to give slightly more descriptive change summaries.

Reviewed by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Neal Gompa <ngompa@datto.com>
Closes #8250
This commit is contained in:
Neal Gompa (ニール・ゴンパ) 2019-01-08 12:23:05 -05:00 committed by Tony Hutter
parent 7e5def8ae0
commit b0d579bc55
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/CONTRIBUTING.md vendored
View File

@ -161,7 +161,7 @@ coding convention.
### Commit Message Formats ### Commit Message Formats
#### New Changes #### New Changes
Commit messages for new changes must meet the following guidelines: Commit messages for new changes must meet the following guidelines:
* In 50 characters or less, provide a summary of the change as the * In 72 characters or less, provide a summary of the change as the
first line in the commit message. first line in the commit message.
* A body which provides a description of the change. If necessary, * A body which provides a description of the change. If necessary,
please summarize important information such as why the proposed please summarize important information such as why the proposed

6
scripts/commitcheck.sh
View File

@ -50,10 +50,10 @@ function new_change_commit()
{ {
error=0 error=0
# subject is not longer than 50 characters # subject is not longer than 72 characters
long_subject=$(git log -n 1 --pretty=%s "$REF" | grep -E -m 1 '.{51}') long_subject=$(git log -n 1 --pretty=%s "$REF" | grep -E -m 1 '.{73}')
if [ -n "$long_subject" ]; then if [ -n "$long_subject" ]; then
echo "error: commit subject over 50 characters" echo "error: commit subject over 72 characters"
error=1 error=1
fi fi