From ad635071355255a43469daa41fd411881407d861 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Fri, 18 Jan 2019 11:11:47 -0800 Subject: [PATCH] Remove zfs_sync() panicking kernel check This check provides no real additional protection and unnecessarily introduces a dependency on the "oops_in_progress" kernel symbol. Remove the check, it there are special circumstances on other platforms which make this a requirement it can be reintroduced for all relevant call paths in a more portable comprehensive manor. Reviewed-by: Matt Ahrens Reviewed-by: George Melikov Signed-off-by: Brian Behlendorf Closes #8297 --- module/zfs/zfs_vfsops.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/module/zfs/zfs_vfsops.c b/module/zfs/zfs_vfsops.c index 74f444ebf..c9e314caa 100644 --- a/module/zfs/zfs_vfsops.c +++ b/module/zfs/zfs_vfsops.c @@ -258,13 +258,6 @@ zfs_sync(struct super_block *sb, int wait, cred_t *cr) { zfsvfs_t *zfsvfs = sb->s_fs_info; - /* - * Data integrity is job one. We don't want a compromised kernel - * writing to the storage pool, so we never sync during panic. - */ - if (unlikely(oops_in_progress)) - return (0); - /* * Semantically, the only requirement is that the sync be initiated. * The DMU syncs out txgs frequently, so there's nothing to do.