From aa6f0f878bb983291b96dda73a6ff7ceef81e00e Mon Sep 17 00:00:00 2001 From: Rob Norris Date: Tue, 19 Aug 2025 16:08:15 +1000 Subject: [PATCH] dnode: remove dn_dirtyctx_firstset Old debug param, not used for anything. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Reviewed-by: Brian Behlendorf Reviewed-by: Robert Evans Reviewed-by: Adam Moss Reviewed-by: Alexander Motin Signed-off-by: Rob Norris Closes #16297 Closes #17652 Closes #17658 --- include/sys/dmu_impl.h | 1 - include/sys/dnode.h | 1 - module/zfs/dnode.c | 7 ------- 3 files changed, 9 deletions(-) diff --git a/include/sys/dmu_impl.h b/include/sys/dmu_impl.h index ed5a3062d..69c0871e3 100644 --- a/include/sys/dmu_impl.h +++ b/include/sys/dmu_impl.h @@ -173,7 +173,6 @@ extern "C" { * dn_notxholds * dn_nodnholds * dn_dirtyctx - * dn_dirtyctx_firstset * (dn_phys copy fields?) * (dn_phys contents?) * held from: diff --git a/include/sys/dnode.h b/include/sys/dnode.h index 50ddafe99..843494c09 100644 --- a/include/sys/dnode.h +++ b/include/sys/dnode.h @@ -344,7 +344,6 @@ struct dnode { kcondvar_t dn_notxholds; kcondvar_t dn_nodnholds; enum dnode_dirtycontext dn_dirtyctx; - const void *dn_dirtyctx_firstset; /* dbg: contents meaningless */ /* protected by own devices */ zfs_refcount_t dn_tx_holds; diff --git a/module/zfs/dnode.c b/module/zfs/dnode.c index 34c4e1ccd..7e445cd91 100644 --- a/module/zfs/dnode.c +++ b/module/zfs/dnode.c @@ -174,7 +174,6 @@ dnode_cons(void *arg, void *unused, int kmflag) dn->dn_free_txg = 0; dn->dn_assigned_txg = 0; dn->dn_dirtyctx = 0; - dn->dn_dirtyctx_firstset = NULL; dn->dn_dirtycnt = 0; dn->dn_bonus = NULL; dn->dn_have_spill = B_FALSE; @@ -230,7 +229,6 @@ dnode_dest(void *arg, void *unused) ASSERT0(dn->dn_free_txg); ASSERT0(dn->dn_assigned_txg); ASSERT0(dn->dn_dirtyctx); - ASSERT0P(dn->dn_dirtyctx_firstset); ASSERT0(dn->dn_dirtycnt); ASSERT0P(dn->dn_bonus); ASSERT(!dn->dn_have_spill); @@ -695,7 +693,6 @@ dnode_destroy(dnode_t *dn) dn->dn_dirtycnt = 0; dn->dn_dirtyctx = 0; - dn->dn_dirtyctx_firstset = NULL; if (dn->dn_bonus != NULL) { mutex_enter(&dn->dn_bonus->db_mtx); dbuf_destroy(dn->dn_bonus); @@ -803,7 +800,6 @@ dnode_allocate(dnode_t *dn, dmu_object_type_t ot, int blocksize, int ibs, dn->dn_dirtyctx = 0; dn->dn_free_txg = 0; - dn->dn_dirtyctx_firstset = NULL; dn->dn_dirtycnt = 0; dn->dn_allocated_txg = tx->tx_txg; @@ -956,7 +952,6 @@ dnode_move_impl(dnode_t *odn, dnode_t *ndn) ndn->dn_free_txg = odn->dn_free_txg; ndn->dn_assigned_txg = odn->dn_assigned_txg; ndn->dn_dirtyctx = odn->dn_dirtyctx; - ndn->dn_dirtyctx_firstset = odn->dn_dirtyctx_firstset; ndn->dn_dirtycnt = odn->dn_dirtycnt; ASSERT0(zfs_refcount_count(&odn->dn_tx_holds)); zfs_refcount_transfer(&ndn->dn_holds, &odn->dn_holds); @@ -1021,7 +1016,6 @@ dnode_move_impl(dnode_t *odn, dnode_t *ndn) odn->dn_free_txg = 0; odn->dn_assigned_txg = 0; odn->dn_dirtyctx = 0; - odn->dn_dirtyctx_firstset = NULL; odn->dn_dirtycnt = 0; odn->dn_have_spill = B_FALSE; odn->dn_zio = NULL; @@ -2238,7 +2232,6 @@ dnode_set_dirtyctx(dnode_t *dn, dmu_tx_t *tx, const void *tag) dn->dn_dirtyctx = DN_DIRTY_SYNC; else dn->dn_dirtyctx = DN_DIRTY_OPEN; - dn->dn_dirtyctx_firstset = tag; } if (ds != NULL) { rrw_exit(&ds->ds_bp_rwlock, tag);