c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-08-04 14:07:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

lzc_ioctl_fd: add ZFS_IOC_TRACE envvar to enable ioctl tracing

Browse Source 
When set, dumps all ZFS ioctl calls and returns and their nvlists to
STDERR, to make debugging and understanding a lot easier.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes #17344
This commit is contained in:
Rob Norris 2024-12-28 15:27:26 +11:00 committed by Brian Behlendorf
parent c4c3917b2a
commit a387b7599c
1 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
lib/libzfs_core/libzfs_core.c
View File

@ -102,6 +102,8 @@ static int g_fd = -1;
static pthread_mutex_t g_lock = PTHREAD_MUTEX_INITIALIZER; static pthread_mutex_t g_lock = PTHREAD_MUTEX_INITIALIZER;
static int g_refcount; static int g_refcount;
static int g_ioc_trace = 0;
#ifdef ZFS_DEBUG #ifdef ZFS_DEBUG
static zfs_ioc_t fail_ioc_cmd = ZFS_IOC_LAST; static zfs_ioc_t fail_ioc_cmd = ZFS_IOC_LAST;
static zfs_errno_t fail_ioc_err; static zfs_errno_t fail_ioc_err;
@ -154,6 +156,10 @@ libzfs_core_init(void)
#ifdef ZFS_DEBUG #ifdef ZFS_DEBUG
libzfs_core_debug_ioc(); libzfs_core_debug_ioc();
#endif #endif
if (getenv("ZFS_IOC_TRACE"))
g_ioc_trace = 1;
(void) pthread_mutex_unlock(&g_lock); (void) pthread_mutex_unlock(&g_lock);
return (0); return (0);
} }
@ -176,7 +182,37 @@ libzfs_core_fini(void)
int int
lzc_ioctl_fd(int fd, unsigned long ioc, zfs_cmd_t *zc) lzc_ioctl_fd(int fd, unsigned long ioc, zfs_cmd_t *zc)
{ {
if (!g_ioc_trace)
return (lzc_ioctl_fd_os(fd, ioc, zc)); return (lzc_ioctl_fd_os(fd, ioc, zc));
nvlist_t *nvl;
fprintf(stderr, "=== lzc_ioctl: call: ioc=0x%lx name=%s\n",
ioc, zc->zc_name[0] ? zc->zc_name : "[none]");
if (zc->zc_nvlist_src) {
nvl = fnvlist_unpack(
(void *)(uintptr_t)zc->zc_nvlist_src,
zc->zc_nvlist_src_size);
nvlist_print(stderr, nvl);
fnvlist_free(nvl);
}
int rc = lzc_ioctl_fd_os(fd, ioc, zc);
int err = errno;
fprintf(stderr, "=== lzc_ioctl: result: ioc=0x%lx name=%s "
"rc=%d errno=%d\n", ioc, zc->zc_name[0] ? zc->zc_name : "[none]",
rc, (rc < 0 ? err : 0));
if (rc >= 0 && zc->zc_nvlist_dst) {
nvl = fnvlist_unpack(
(void *)(uintptr_t)zc->zc_nvlist_dst,
zc->zc_nvlist_dst_size);
nvlist_print(stderr, nvl);
fnvlist_free(nvl);
}
errno = err;
return (rc);
} }
static int static int