From 9fd5fedc677f79ce79ecff6595a9360bbfe0ffb1 Mon Sep 17 00:00:00 2001 From: Richard Yao Date: Wed, 1 Mar 2023 16:20:53 -0500 Subject: [PATCH] Remove bad kmem_free() oversight from previous zfsdev_state_list patch I forgot to remove the corresponding kmem_free() from zfs_kmod_fini() in 9a14ce43c3d6a9939804215bbbe66de5115ace42. Clang's static analyzer did not complain, but the Coverity scan that was run after the patch was merged did. Reviewed-by: Brian Behlendorf Reviewed-by: Tino Reichardt Signed-off-by: Richard Yao Reported-by: Coverity (CID-1535275) Closes #14556 --- module/zfs/zfs_ioctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/module/zfs/zfs_ioctl.c b/module/zfs/zfs_ioctl.c index 7b4b0dff8..24ae0a00d 100644 --- a/module/zfs/zfs_ioctl.c +++ b/module/zfs/zfs_ioctl.c @@ -7862,7 +7862,6 @@ zfs_kmod_fini(void) zfs_onexit_destroy(zs->zs_onexit); if (zs->zs_zevent) zfs_zevent_destroy(zs->zs_zevent); - kmem_free(zs, sizeof (zfsdev_state_t)); } zfs_ereport_taskq_fini(); /* run before zfs_fini() on Linux */