From 9585538d0e2d4c1a0966d19343f56c02bfd755c6 Mon Sep 17 00:00:00 2001 From: Ryan Moeller Date: Wed, 4 Nov 2020 23:10:12 +0000 Subject: [PATCH] Const some unchanging variables in zfs_write Show that these values will not be changing later. Reviewed-by: Brian Behlendorf Reviewed-by: Matt Macy Reviewed-by: Alexander Motin Signed-off-by: Ryan Moeller Closes #11176 --- module/zfs/zfs_vnops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/module/zfs/zfs_vnops.c b/module/zfs/zfs_vnops.c index 4cc01753e..8728790b5 100644 --- a/module/zfs/zfs_vnops.c +++ b/module/zfs/zfs_vnops.c @@ -234,7 +234,7 @@ zfs_write(znode_t *zp, uio_t *uio, int ioflag, cred_t *cr) if (n == 0) return (0); - rlim64_t limit = MAXOFFSET_T; + const rlim64_t limit = MAXOFFSET_T; zfsvfs_t *zfsvfs = ZTOZSB(zp); ZFS_ENTER(zfsvfs); @@ -278,7 +278,7 @@ zfs_write(znode_t *zp, uio_t *uio, int ioflag, cred_t *cr) return (SET_ERROR(EINVAL)); } - int max_blksz = zfsvfs->z_max_blksz; + const uint64_t max_blksz = zfsvfs->z_max_blksz; /* * Pre-fault the pages to ensure slow (eg NFS) pages @@ -582,7 +582,7 @@ zfs_write(znode_t *zp, uio_t *uio, int ioflag, cred_t *cr) zfsvfs->z_os->os_sync == ZFS_SYNC_ALWAYS) zil_commit(zilog, zp->z_id); - int64_t nwritten = start_resid - uio->uio_resid; + const int64_t nwritten = start_resid - uio->uio_resid; dataset_kstats_update_write_kstats(&zfsvfs->z_kstat, nwritten); task_io_account_write(nwritten);