c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-26 03:09:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve l2arc reporting in arc_summary.

Browse Source 
- Do not report L2ARC as FAULTED in presence of in-flight writes.
- Report read and write I/Os, bytes and errors.
- Remove few numbers not important to average user.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes #12304 
Closes #14946
This commit is contained in:
Alexander Motin 2023-06-09 13:14:05 -04:00 committed by GitHub
parent b3ad3f48d9
commit 90ccfd426d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
cmd/arc_summary
View File

@ -842,7 +842,8 @@ def section_l2arc(kstats_dict):
('Free on write:', 'l2_free_on_write'), ('Free on write:', 'l2_free_on_write'),
('R/W clashes:', 'l2_rw_clash'), ('R/W clashes:', 'l2_rw_clash'),
('Bad checksums:', 'l2_cksum_bad'), ('Bad checksums:', 'l2_cksum_bad'),
('I/O errors:', 'l2_io_error')) ('Read errors:', 'l2_io_error'),
('Write errors:', 'l2_writes_error'))
for title, value in l2_todo: for title, value in l2_todo:
prt_i1(title, f_hits(arc_stats[value])) prt_i1(title, f_hits(arc_stats[value]))
@ -878,28 +879,20 @@ def section_l2arc(kstats_dict):
prt_i2('Miss ratio:', prt_i2('Miss ratio:',
f_perc(arc_stats['l2_misses'], l2_access_total), f_perc(arc_stats['l2_misses'], l2_access_total),
f_hits(arc_stats['l2_misses'])) f_hits(arc_stats['l2_misses']))
prt_i1('Feeds:', f_hits(arc_stats['l2_feeds']))
print() print()
print('L2ARC writes:') print('L2ARC I/O:')
prt_i2('Reads:',
if arc_stats['l2_writes_done'] != arc_stats['l2_writes_sent']: f_bytes(arc_stats['l2_read_bytes']),
prt_i2('Writes sent:', 'FAULTED', f_hits(arc_stats['l2_writes_sent'])) f_hits(arc_stats['l2_hits']))
prt_i2('Done ratio:', prt_i2('Writes:',
f_perc(arc_stats['l2_writes_done'], f_bytes(arc_stats['l2_write_bytes']),
arc_stats['l2_writes_sent']), f_hits(arc_stats['l2_writes_sent']))
f_hits(arc_stats['l2_writes_done']))
prt_i2('Error ratio:',
f_perc(arc_stats['l2_writes_error'],
arc_stats['l2_writes_sent']),
f_hits(arc_stats['l2_writes_error']))
else:
prt_i2('Writes sent:', '100 %', f_hits(arc_stats['l2_writes_sent']))
print() print()
print('L2ARC evicts:') print('L2ARC evicts:')
prt_i1('Lock retries:', f_hits(arc_stats['l2_evict_lock_retry'])) prt_i1('L1 cached:', f_hits(arc_stats['l2_evict_l1cached']))
prt_i1('Upon reading:', f_hits(arc_stats['l2_evict_reading'])) prt_i1('While reading:', f_hits(arc_stats['l2_evict_reading']))
print() print()