c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-01-27 10:24:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup: Use C99 flexible array members instead of zero length arrays

Browse Source 
The Linux 5.16.14 kernel's coccicheck caught this. The semantic
patch that caught it was:

./scripts/coccinelle/misc/flexible_array.cocci

The Linux kernel's documentation makes a good case for why we should not
use these:

https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14372
This commit is contained in:
Richard Yao 2023-01-10 15:14:59 -05:00 committed by Brian Behlendorf
parent c9c3ce7976
commit 8e7ebf4e2d
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
module/os/linux/spl/spl-zone.c
View File

@ -50,7 +50,7 @@ typedef struct zone_datasets {
typedef struct zone_dataset { typedef struct zone_dataset {
struct list_head zd_list; /* zone_dataset linkage */ struct list_head zd_list; /* zone_dataset linkage */
size_t zd_dsnamelen; /* length of name */ size_t zd_dsnamelen; /* length of name */
char zd_dsname[0]; /* name of the member dataset */ char zd_dsname[]; /* name of the member dataset */
} zone_dataset_t; } zone_dataset_t;
#if defined(CONFIG_USER_NS) && defined(HAVE_USER_NS_COMMON_INUM) #if defined(CONFIG_USER_NS) && defined(HAVE_USER_NS_COMMON_INUM)

2
module/os/linux/zfs/vdev_disk.c
View File

@ -71,7 +71,7 @@ typedef struct dio_request {
atomic_t dr_ref; /* References */ atomic_t dr_ref; /* References */
int dr_error; /* Bio error */ int dr_error; /* Bio error */
int dr_bio_count; /* Count of bio's */ int dr_bio_count; /* Count of bio's */
struct bio *dr_bio[0]; /* Attached bio's */ struct bio *dr_bio[]; /* Attached bio's */
} dio_request_t; } dio_request_t;
/* /*

2
module/zfs/dsl_scan.c
View File

@ -281,7 +281,7 @@ typedef struct scan_io {
* event of an error. This array must go at the end of the * event of an error. This array must go at the end of the
* struct to allow this for the variable number of elements. * struct to allow this for the variable number of elements.
*/ */
dva_t sio_dva[0]; dva_t sio_dva[];
} scan_io_t; } scan_io_t;
#define SIO_SET_OFFSET(sio, x) DVA_SET_OFFSET(&(sio)->sio_dva[0], x) #define SIO_SET_OFFSET(sio, x) DVA_SET_OFFSET(&(sio)->sio_dva[0], x)