Add --enable=all to ShellCheck by default

Change enforced shell type from `dash` to `sh` and excluded
`SC2039` and `SC3043` by default. `local` keyword is accepted by all
POSIX shells from practical point of view. There is no need anymore
to enforce dash so `local` is accepted.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes #13020

cmd/Makefile.am

@@ -9,7 +9,6 @@ CPPCHECKDIRS += raidz_test zfs_ids_to_path zpool_influxdb
 
 # TODO: #12084: SHELLCHECKDIRS += vdev_id
 SHELLCHECKDIRS = fsck_zfs zed zpool zvol_wait
-SHELLCHECK_OPTS = --enable=all
 
 if USING_PYTHON
 SUBDIRS += arcstat arc_summary dbufstat

cmd/fsck_zfs/Makefile.am

@@ -5,4 +5,3 @@ dist_sbin_SCRIPTS = fsck.zfs
 
 SUBSTFILES += $(dist_sbin_SCRIPTS)
 
-SHELLCHECK_OPTS = --enable=all

cmd/zed/Makefile.am

@@ -5,7 +5,6 @@ AM_CFLAGS += $(LIBUDEV_CFLAGS) $(LIBUUID_CFLAGS)
 
 SUBDIRS = zed.d
 SHELLCHECKDIRS = $(SUBDIRS)
-SHELLCHECK_OPTS = --enable=all
 
 sbin_PROGRAMS = zed
 

cmd/zed/zed.d/Makefile.am

@@ -11,8 +11,7 @@ dist_zedconf_DATA = \
 	zed.rc
 
 SHELLCHECKSCRIPTS = zed-functions.sh zed.rc
-SHELLCHECK_OPTS = --enable=all
-SHELLCHECK_SHELL = dash
+SHELLCHECK_SHELL = sh
 
 zedexecdir = $(zfsexecdir)/zed.d
 

cmd/zpool/Makefile.am

@@ -5,7 +5,6 @@ AM_CFLAGS += $(LIBBLKID_CFLAGS) $(LIBUUID_CFLAGS)
 
 DEFAULT_INCLUDES += -I$(srcdir)
 
-SHELLCHECK_OPTS = --enable=all
 
 sbin_PROGRAMS = zpool
 

cmd/zvol_wait/Makefile.am

@@ -2,4 +2,3 @@ include $(top_srcdir)/config/Shellcheck.am
 
 dist_bin_SCRIPTS = zvol_wait
 
-SHELLCHECK_OPTS = --enable=all