c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-05-22 02:27:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix coverity defects

Browse Source 
Fix coverity defects:
coverity scan CID:147623, Type: Resource leak.
coverity scan CID:147622, Type: Resource leak.
reason: zpool_open zhp, but not zpool_close zhp. so resource leak.

coverity scan CID:147621, Type: Resource fd leak.
coverity scan CID:147620, Type: Resource fd leak.
reason: do_write do_read open file fd,but exception not close fd.

delete unuse definition DMU_OS_IS_L2COMPRESSIBLE.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: cao.xuewen <cao.xuewen@zte.com.cn>
Closes #5137
This commit is contained in:
cao
2016-09-21 08:45:45 +08:00
committed by Brian Behlendorf
parent d2a6f65cfb
commit 884385a0b2
4 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/zinject/translate.c
+2
View File
@@ -474,6 +474,7 @@ translate_device(const char *pool, const char *device, err_type_t label_type,
if (tgt == NULL) {
(void) fprintf(stderr, "cannot find device '%s' in "
"pool '%s'\n", device, pool);
zpool_close(zhp);
return (-1);
}
@@ -515,5 +516,6 @@ translate_device(const char *pool, const char *device, err_type_t label_type,
record->zi_end = record->zi_start + VDEV_PAD_SIZE - 1;
break;
}
zpool_close(zhp);
return (0);
}
cmd/zpool/zpool_main.c
+2 -1
View File
@@ -758,7 +758,7 @@ zpool_do_remove(int argc, char **argv)
{
char *poolname;
int i, ret = 0;
zpool_handle_t *zhp;
zpool_handle_t *zhp = NULL;
argc--;
argv++;
@@ -782,6 +782,7 @@ zpool_do_remove(int argc, char **argv)
if (zpool_vdev_remove(zhp, argv[i]) != 0)
ret = 1;
}
zpool_close(zhp);
return (ret);
}