From 863e38453ee537ab59b3729b32d9d88ca2b884bc Mon Sep 17 00:00:00 2001 From: Ryan Moeller Date: Thu, 3 Sep 2020 19:23:30 +0000 Subject: [PATCH] Prune dead branch reported by Coverity wkey is NULL at every `goto error;`. dcp is never NULL. Reviewed-by: Brian Behlendorf Signed-off-by: Ryan Moeller Closes #10884 --- module/zfs/dsl_crypt.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/module/zfs/dsl_crypt.c b/module/zfs/dsl_crypt.c index 33c21e86c..26d4c2fe7 100644 --- a/module/zfs/dsl_crypt.c +++ b/module/zfs/dsl_crypt.c @@ -235,11 +235,7 @@ dsl_crypto_params_create_nvlist(dcp_cmd_t cmd, nvlist_t *props, return (0); error: - if (wkey != NULL) - dsl_wrapping_key_free(wkey); - if (dcp != NULL) - kmem_free(dcp, sizeof (dsl_crypto_params_t)); - + kmem_free(dcp, sizeof (dsl_crypto_params_t)); *dcp_out = NULL; return (ret); }