mirror of
				https://git.proxmox.com/git/mirror_zfs.git
				synced 2025-10-26 18:05:04 +03:00 
			
		
		
		
	zfs_log: make zfs_immediate_write_sz uint
Likely it's only int64 for comparison with ssize_t, which is signed. However, it would make no sense for it to be less than 0 or greater than 4G, so making it a regular uint will make it safe for comparison and remove the only S64 tunable in core. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Pavel Snajdr <snajpa@snajpa.net> Signed-off-by: Rob Norris <robn@despairlabs.com> Closes #17377
This commit is contained in:
		
							parent
							
								
									65cf521353
								
							
						
					
					
						commit
						8317244270
					
				| @ -607,7 +607,7 @@ zfs_log_rename_whiteout(zilog_t *zilog, dmu_tx_t *tx, uint64_t txtype, | |||||||
|  * called as soon as the write is on stable storage (be it via a DMU sync or a |  * called as soon as the write is on stable storage (be it via a DMU sync or a | ||||||
|  * ZIL commit). |  * ZIL commit). | ||||||
|  */ |  */ | ||||||
| static int64_t zfs_immediate_write_sz = 32768; | static uint_t zfs_immediate_write_sz = 32768; | ||||||
| 
 | 
 | ||||||
| void | void | ||||||
| zfs_log_write(zilog_t *zilog, dmu_tx_t *tx, int txtype, | zfs_log_write(zilog_t *zilog, dmu_tx_t *tx, int txtype, | ||||||
| @ -935,5 +935,5 @@ zfs_log_clone_range(zilog_t *zilog, dmu_tx_t *tx, int txtype, znode_t *zp, | |||||||
| 	} | 	} | ||||||
| } | } | ||||||
| 
 | 
 | ||||||
| ZFS_MODULE_PARAM(zfs, zfs_, immediate_write_sz, S64, ZMOD_RW, | ZFS_MODULE_PARAM(zfs, zfs_, immediate_write_sz, UINT, ZMOD_RW, | ||||||
| 	"Largest data block to write to zil"); | 	"Largest data block to write to zil"); | ||||||
|  | |||||||
		Loading…
	
		Reference in New Issue
	
	Block a user
	 Rob Norris
						Rob Norris