From 73d08ace523fc3964852e4e82eae3f2db70354d4 Mon Sep 17 00:00:00 2001 From: Tony Hutter Date: Mon, 16 Apr 2018 15:40:14 -0700 Subject: [PATCH] Exclude python scripts from RPM shebang check The newest Fedora packaging rules print warnings for scripts using the /usr/bin/python shebang: *** WARNING: mangling shebang in /usr/src/spl-0.7.0/cmd/splslab/splslab.py from #!/usr/bin/python to #!/usr/bin/python2. This will become an ERROR, fix it manually! Fedora wants all cross compatible scripts to pick python3. Since we don't want our users to have to pick a specific version of python, we exclude our scripts from the RPM build check. Reviewed-by: Brian Behlendorf Signed-off-by: Tony Hutter Closes: #699 Closes: #700 --- rpm/generic/spl-dkms.spec.in | 10 ++++++++++ rpm/generic/spl.spec.in | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/rpm/generic/spl-dkms.spec.in b/rpm/generic/spl-dkms.spec.in index 419624058..a8691d229 100644 --- a/rpm/generic/spl-dkms.spec.in +++ b/rpm/generic/spl-dkms.spec.in @@ -7,6 +7,16 @@ %define module @PACKAGE@ %define mkconf scripts/dkms.mkconf +# Python permits the !/usr/bin/python shebang for scripts that are cross +# compatible between python2 and python3, but Fedora 28 does not. Fedora +# wants us to choose python3 for cross-compatible scripts. Since we want +# to support python2 and python3 users, exclude our scripts from Fedora 28's +# RPM build check, so that we don't get a bunch of build warnings. +# +# Details: https://github.com/zfsonlinux/zfs/issues/7360 +# +%global __brp_mangle_shebangs_exclude_from splslab.py + Name: %{module}-dkms Version: @VERSION@ diff --git a/rpm/generic/spl.spec.in b/rpm/generic/spl.spec.in index 8fee0b87e..7ba71fd58 100644 --- a/rpm/generic/spl.spec.in +++ b/rpm/generic/spl.spec.in @@ -1,3 +1,13 @@ +# Python permits the !/usr/bin/python shebang for scripts that are cross +# compatible between python2 and python3, but Fedora 28 does not. Fedora +# wants us to choose python3 for cross-compatible scripts. Since we want +# to support python2 and python3 users, exclude our scripts from Fedora 28's +# RPM build check, so that we don't get a bunch of build warnings. +# +# Details: https://github.com/zfsonlinux/zfs/issues/7360 +# +%global __brp_mangle_shebangs_exclude_from splslab.py + Name: @PACKAGE@ Version: @VERSION@ Release: @RELEASE@%{?dist}