mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2026-05-24 11:18:52 +03:00
Wire O_DIRECT also to Uncached I/O (#17218)
Before Direct I/O was implemented, I've implemented lighter version I called Uncached I/O. It uses normal DMU/ARC data path with some optimizations, but evicts data from caches as soon as possible and reasonable. Originally I wired it only to a primarycache property, but now completing the integration all the way up to the VFS. While Direct I/O has the lowest possible memory bandwidth usage, it also has a significant number of limitations. It require I/Os to be page aligned, does not allow speculative prefetch, etc. The Uncached I/O does not have those limitations, but instead require additional memory copy, though still one less than regular cached I/O. As such it should fill the gap in between. Considering this I've disabled annoying EINVAL errors on misaligned requests, adding a tunable for those who wants to test their applications. To pass the information between the layers I had to change a number of APIs. But as side effect upper layers can now control not only the caching, but also speculative prefetch. I haven't wired it to VFS yet, since it require looking on some OS specifics. But while there I've implemented speculative prefetch of indirect blocks for Direct I/O, controllable via all the same mechanisms. Signed-off-by: Alexander Motin <mav@FreeBSD.org> Sponsored by: iXsystems, Inc. Fixes #17027 Reviewed-by: Rob Norris <robn@despairlabs.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
This commit is contained in:
@@ -2332,12 +2332,11 @@ dmu_objset_userquota_get_ids(dnode_t *dn, boolean_t before, dmu_tx_t *tx)
|
||||
data = DN_BONUS(dn->dn_phys);
|
||||
}
|
||||
} else if (dn->dn_bonuslen == 0 && dn->dn_bonustype == DMU_OT_SA) {
|
||||
int rf = 0;
|
||||
dmu_flags_t rf = DB_RF_MUST_SUCCEED;
|
||||
|
||||
if (RW_WRITE_HELD(&dn->dn_struct_rwlock))
|
||||
rf |= DB_RF_HAVESTRUCT;
|
||||
error = dmu_spill_hold_by_dnode(dn,
|
||||
rf | DB_RF_MUST_SUCCEED,
|
||||
error = dmu_spill_hold_by_dnode(dn, rf,
|
||||
FTAG, (dmu_buf_t **)&db);
|
||||
ASSERT(error == 0);
|
||||
mutex_enter(&db->db_mtx);
|
||||
|
||||
Reference in New Issue
Block a user