mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2026-05-22 02:27:36 +03:00
Deprecate deduplicated send streams
Dedup send can only deduplicate over the set of blocks in the send command being invoked, and it does not take advantage of the dedup table to do so. This is a very common misconception among not only users, but developers, and makes the feature seem more useful than it is. As a result, many users are using the feature but not getting any benefit from it. Dedup send requires a nontrivial expenditure of memory and CPU to operate, especially if the dataset(s) being sent is (are) not already using a dedup-strength checksum. Dedup send adds developer burden. It expands the test matrix when developing new features, causing bugs in released code, and delaying development efforts by forcing more testing to be done. As a result, we are deprecating the use of `zfs send -D` and receiving of such streams. This change adds a warning to the man page, and also prints the warning whenever dedup send or receive are used. In a future release, we plan to: 1. remove the kernel code for generating deduplicated streams 2. make `zfs send -D` generate regular, non-deduplicated streams 3. remove the kernel code for receiving deduplicated streams 4. make `zfs receive` of deduplicated streams process them in userland to "re-duplicate" them, so that they can still be received. Reviewed-by: Paul Dagnelie <pcd@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Closes #7887 Closes #10117
This commit is contained in:
@@ -105,6 +105,18 @@ destroyed by using the
|
||||
.Nm zfs Cm destroy Fl d
|
||||
command.
|
||||
.Pp
|
||||
Deduplicated send streams can be generated by using the
|
||||
.Nm zfs Cm send Fl D
|
||||
command.
|
||||
\fBThe ability to send and receive deduplicated send streams is deprecated.\fR
|
||||
In the future, the ability to receive a deduplicated send stream with
|
||||
.Nm zfs Cm receive
|
||||
will be removed.
|
||||
However, in the future, a utility will be provided to convert a
|
||||
deduplicated send stream to a regular (non-deduplicated) stream.
|
||||
This future utility will require that the send stream be located in a
|
||||
seek-able file, rather than provided by a pipe.
|
||||
.Pp
|
||||
If
|
||||
.Fl o Em property Ns = Ns Ar value
|
||||
or
|
||||
|
||||
@@ -87,6 +87,9 @@ By default, a full stream is generated.
|
||||
.Bl -tag -width "-D"
|
||||
.It Fl D, -dedup
|
||||
Generate a deduplicated stream.
|
||||
\fBDeduplicated send is deprecated and will be removed in a future release.\fR
|
||||
(In the future, the flag will be accepted but a regular, non-deduplicated
|
||||
stream will be generated.)
|
||||
Blocks which would have been sent multiple times in the send stream will only be
|
||||
sent once.
|
||||
The receiving system must also support this feature to receive a deduplicated
|
||||
|
||||
Reference in New Issue
Block a user